How do you know when the stream ends?

[nichoth]

How do you tell when a ws connection closes if you are using pull-ws and muxrpc? I see pull-goodbye but I'm not sure how to use it.

[dominictarr]

pull-goodbye is already used in muxrpc https://github.com/ssbc/muxrpc/blob/master/stream.js#L99-L101

are you getting a ws stream that ends and muxrpc doesn't realize?

[nichoth]

hmm. I'm not sure where to get a cb for the end event. We have a normal situation on the server like:

ws({ server: server }, function onWsConnect (wsStream) {
   pull( myService, wsStream, myService )
})

Thanks

[nichoth]

A through stream like this works. Is this a good way to do it?

function OnEnd (cb) {
    return function sink (read) {
        return function source (abort, _cb) {
            if (abort) {
                console.log('abort', abort)
                cb()
            }
            read(abort, function onNext (end, data) {
                if (end === true) cb()
                _cb(end, data)
            })
        }
    }
}

[dominictarr]

one way is that rpc.createStream(cb) has takes a callback,
so you can do:

createServer(function (stream) {
  var serverRPC = MRPC(null, api) ({
    hello: function (name, cb) {
      cb(null, 'hello, ' + name + '!')
    } //etc...
  })

  var serverStream = serverRPC.createStream(function callback (err) {
    //this is called when the connection ends
  })

  pull(stream, serverStream, stream) //pipe together
})

note, that when the stream ends, you can create another stream and keep that rpc object, which you might want to do on client objects, but not servers.

[dominictarr]

ah, also the rpc object emits a closed event. which is how it's done in secret-stack

[nichoth]

Thanks @dominictarr ! I went ahead and submitted a PR in muxrpc to add those to the readme.