Missing upgrades and upgraded values in cards

[jarnomaaniemi]

So, I went through manually some of the Common and Uncommon cards and found out some bug "patterns" and missing upgraded values. I stopped manually going through after Darkness with Uncommon A->Z filter.

Patterns

• some of the cards data actually have null on upgrade key -> a test function/file might help find all the missing upgrades as every cards has a uprade.
• stars image is shown incorrectly now f.e. instead of two stars (image) it shows [star:2] in grid view and 2] card view.
• Orbs values is not upgrading in views. Data has this value increase as "repeat".

Individual Cards

Missing upgrade (Hammer icon)

• Armaments missing upgrade on grid view and card view: "upgrade": null. Upgrade is "Gain 5 Block. Upgrade ALL cards in your Hand."
• CHARGE!! missing upgrade on grid view and card view: "upgrade": null. Upgrades spawn_cards: MINION_STRIKE to MINION_STRIKE+
• Darkness missing upgrade on grid view and card view "upgrade": null. Upgrade is "Channel 1 Dark. Trigger the passive ability of all Dark twice."

Stars showing incorrectly:

• Glow+ in place of stars is [star:2] in grid view, 2] in card view
• Hidden Cache+ [star:4] in grid view, 4] in card view
• Solar Strike+ [star:2] in grid view, 2] in card view
• Venerate+ [star:3] in grid view, 3] in card view

Missing upgraded Orbs

• Capasitor+ missing upgraded value 2->3 Orb Slots. Weirdly in data as Repeat: +1
• Chaos+ missing upgraded value (same as Capasitor, repeat +1) 1->2 random Orbs.

Uncommon

• Bulk Up+ missing upgraded values (+1) on Strength and Dexterity
• Capture Spirit missing upgraded values "upgrade": { "damage": "+1", "cards": "+1" } that would translate to "Enemy loses 4 HP. Add 4 Souls into your Draw Pile."
• Convergence+ missing gain stars value "upgrade": { "stars": "+1" }

[jarnomaaniemi]

=== Card Upgrade Validation ===

Total cards: 576
✅ With upgrade: 522
❌ Without upgrade (NULL): 54

These cards are missing upgrade data:

• ARMAMENTS: Armaments
• ASCENDERS_BANE: Ascender's Bane
• BAD_LUCK: Bad Luck
• BECKON: Beckon
• BURN: Burn
• BYRDONIS_EGG: Byrdonis Egg
• CASCADE: Cascade
• CHARGE: CHARGE!!
• CLUMSY: Clumsy
• CURSE_OF_THE_BELL: Curse of the Bell
• DARKNESS: Darkness
• DAZED: Dazed
• DEBRIS: Debris
• DEBT: Debt
• DECAY: Decay
• DISINTEGRATION: Disintegration
• DOUBT: Doubt
• ENLIGHTENMENT: Enlightenment
• ENTHRALLED: Enthralled
• FOLLY: Folly
• FRANTIC_ESCAPE: Frantic Escape
• GREED: Greed
• GUARDS: GUARDS!!!
• GUILTY: Guilty
• HIDDEN_DAGGERS: Hidden Daggers
• INFECTION: Infection
• INJURY: Injury
• KNIFE_TRAP: Knife Trap
• LANTERN_KEY: Lantern Key
• LARGESSE: Largesse
• MALAISE: Malaise
• MIND_ROT: Mind Rot
• MULTI_CAST: Multi-Cast
• NORMALITY: Normality
• POOR_SLEEP: Poor Sleep
• PRIMAL_FORCE: Primal Force
• QUASAR: Quasar
• REGRET: Regret
• SEANCE: Seance
• SHAME: Shame
• SLIMED: Slimed
• SLOTH: Sloth
• SOOT: Soot
• SPINNER: Spinner
• SPLASH: Splash
• SPOILS_MAP: Spoils Map
• SPORE_MIND: Spore Mind
• STORM_OF_STEEL: Storm of Steel
• TEMPEST: Tempest
• TOXIC: Toxic
• VOID: Void
• WASTE_AWAY: Waste Away
• WOUND: Wound
• WRITHE: Writhe

[ptrlrd]

I think these three cards (Byrdonis Egg, Lantern Key, Spoils Map) are quest cards and do not have an upgrade. Can you confirm @jarnomaaniemi ?

There was something wrong with not having an upgrade_description and is resolvable with an is_upgradable field. This is the same bug that is happening to the stars so a similar fix is happening for it too.

[ptrlrd]

Okay, the following should fix the bugs

• 9249ea3 fixes upgrade data
• 17e637f fixes star icon
• b7395fe fixes times phrasing.
• 59c1794 fixes ambiguous upgrade values when all upgrades are the same

[ptrlrd]

This is from the first batch of issues

From the second batch

From the thidr batch

The third batch is fine.

I found three additional bugs for convergence, one is for the + variant because the energy got regexed to 2], Channel 2 Orb isn't getting regexed to Channel 2 Orbs, gramatically broken but working on a fix, When summon cards with l;ike "Summon minions" or "Summon minions+" it should link to the card.

[ptrlrd]

ARe fixed but I broke CHARGE!! and a few other cards..

[ptrlrd]

List of 36 cards with no upgrades, everything else should have em

• 18 Curses: Ascender's Bane, Bad Luck, Clumsy, Curse of the Bell, Debt, Decay, Doubt, Enthralled, Folly, Greed, Guilty, Injury, Normality,
  Poor Sleep, Regret, Shame, Spore Mind, Writhe
• 3 Quests: Byrdonis Egg, Lantern Key, Spoils Map
• 11 Statuses: Beckon, Burn, Dazed, Debris, Frantic Escape, Infection, Slimed, Soot, Toxic, Void, Wound
• 4 Tokens: Disintegration, Mind Rot, Sloth, Waste Away

[ptrlrd]

Still goofing with this, trying to think of a clean way to tooltip the "Minion Strikes" and Minion Strikes"

[ptrlrd]

https://spire-codex.com/cards/charge now has Minion Strikes tooltip now. :D

[ptrlrd]

I'll give you 24 hours to provide additional feedback otherwise I can will close :)

[jarnomaaniemi]

I might not be able to review this in 24h or this week. Your call! Looks good. Didn't think of curses, event etc. cards. Good catch, so less cards 👍

[ptrlrd]

I'll close the issue. Thanks for submitting