Skip to content

[RV64_DYNAREC] Fixed PCMPISTRM opcode scratch register conflict #3884

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ptitSeb merged 1 commit into from
May 23, 2026
+1 −35
Merged

[RV64_DYNAREC] Fixed PCMPISTRM opcode scratch register conflict #3884

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 1 addition & 35 deletions src/dynarec/rv64/dynarec_rv64_660f38.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -689,40 +689,6 @@ uintptr_t dynarec64_660F38(dynarec_rv64_t* dyn, uintptr_t addr, uint8_t opcode,
SW(x3, gback, gdoffset + i * 4);
}
break;
case 0x61:
Comment thread
ptitSeb marked this conversation as resolved.
INST_NAME("PCMPESTRI Gx, Ex, Ib");
SETFLAGS(X_ALL, SF_SET_DF, NAT_FLAGS_NOFUSION);
nextop = F8;
GETG;
sse_reflect_reg(dyn, ninst, x6, gd);
ADDI(x3, xEmu, offsetof(x64emu_t, xmm[gd]));
if (MODREG) {
ed = (nextop & 7) + (rex.b << 3);
sse_reflect_reg(dyn, ninst, x6, ed);
ADDI(x1, xEmu, offsetof(x64emu_t, xmm[ed]));
ed = x1;
} else {
addr = geted(dyn, addr, ninst, nextop, &ed, x1, x2, &fixedaddress, rex, NULL, 0, 1);
}
// prepare rest arguments
MV(x2, xRDX);
MV(x4, xRAX);
u8 = F8;
MOV32w(x5, u8);
CALL6(const_sse42_compare_string_explicit_len, x1, ed, x2, x3, x4, x5, 0);
ZEROUP(x1);
BNEZ_MARK(x1);
MOV32w(xRCX, (u8 & 1) ? 8 : 16);
B_NEXT_nocond;
MARK;
if (u8 & 0b1000000) {
CLZxw(xRCX, x1, 0, x2, x3, x4);
ADDI(x2, xZR, 31);
SUB(xRCX, x2, xRCX);
} else {
CTZxw(xRCX, x1, 0, x2, x3);
}
break;
case 0xDB:
INST_NAME("AESIMC Gx, Ex"); // AES-NI
nextop = F8;
Expand Down Expand Up @@ -1301,7 +1267,6 @@ uintptr_t dynarec64_660F38(dynarec_rv64_t* dyn, uintptr_t addr, uint8_t opcode,
GETG;
sse_forget_reg(dyn, ninst, x6, gd);
sse_forget_reg(dyn, ninst, x6, 0);
ADDI(x2, xEmu, offsetof(x64emu_t, xmm[gd]));
if (MODREG) {
ed = (nextop & 7) + (rex.b << 3);
sse_reflect_reg(dyn, ninst, x6, ed);
Expand All @@ -1310,6 +1275,7 @@ uintptr_t dynarec64_660F38(dynarec_rv64_t* dyn, uintptr_t addr, uint8_t opcode,
} else {
addr = geted(dyn, addr, ninst, nextop, &ed, x1, x2, &fixedaddress, rex, NULL, 0, 1);
}
ADDI(x2, xEmu, offsetof(x64emu_t, xmm[gd]));
u8 = F8;
ADDI(x3, xZR, u8);
CALL4(const_sse42_compare_string_implicit_len, x1, ed, x2, x3, 0);
Expand Down
Loading