Merge branch 'main' into add-all-wasi-hostcalls

Author: johnlanni

.bazelrc

@@ -10,6 +10,7 @@ build --action_env=PATH
 build:clang --action_env=BAZEL_COMPILER=clang
 build:clang --action_env=CC=clang
 build:clang --action_env=CXX=clang++
+build:clang --copt -Wno-pragma-once-outside-header --cxxopt -Wno-pragma-once-outside-header
 
 # Common flags for Clang sanitizers.
 build:clang-xsan --config=clang
@@ -54,6 +55,7 @@ build:clang-tsan --config=clang-xsan
 build:clang-tsan --copt -DTHREAD_SANITIZER=1
 build:clang-tsan --copt -fsanitize=thread
 build:clang-tsan --linkopt -fsanitize=thread
+build:clang-tsan --test_env=TSAN_OPTIONS=suppressions=bazel/tsan_suppressions.txt
 
 # Use Clang-Tidy tool.
 build:clang-tidy --config=clang
@@ -66,24 +68,22 @@ build:gcc --action_env=BAZEL_COMPILER=gcc
 build:gcc --action_env=CC=gcc
 build:gcc --action_env=CXX=g++
 
-# Use Zig C/C++ compiler.
-build:zig-cc --incompatible_enable_cc_toolchain_resolution
-build:zig-cc --extra_toolchains @zig_sdk//:aarch64-linux-gnu.2.28_toolchain
-build:zig-cc --extra_toolchains @zig_sdk//:x86_64-linux-gnu.2.28_toolchain
-build:zig-cc --host_copt=-fno-sanitize=undefined
+build:hermetic-llvm --incompatible_enable_cc_toolchain_resolution
+build:hermetic-llvm --action_env BAZEL_DO_NOT_DETECT_CPP_TOOLCHAIN=1
+build:hermetic-llvm --extra_toolchains @emsdk//emscripten_toolchain:cc-toolchain-wasm
 
-# Use Zig C/C++ compiler (cross-compile to Linux/aarch64).
-build:zig-cc-linux-aarch64 --config=zig-cc
-build:zig-cc-linux-aarch64 --platforms @zig_sdk//:linux_aarch64_platform
-build:zig-cc-linux-aarch64 --run_under=qemu-aarch64-static
-build:zig-cc-linux-aarch64 --test_env=QEMU_LD_PREFIX=/usr/aarch64-linux-gnu/
+build:hermetic-llvm-macos --config=hermetic-llvm
+# Below flags mitigate https://github.com/bazel-contrib/toolchains_llvm/pull/229.
+build:hermetic-llvm-macos --features=-libtool
+build:hermetic-llvm-macos --features=-supports_dynamic_linker
 
 build --enable_platform_specific_config
 
-# Use C++17.
-build:linux --cxxopt=-std=c++17
-build:macos --cxxopt=-std=c++17
-build:windows --cxxopt="/std:c++17"
+# Use C++20.
+build:linux --cxxopt=-std=c++20 --host_cxxopt=-std=c++20
+build:macos --cxxopt=-std=c++20 --host_cxxopt=-std=c++20
+build:windows --cxxopt="/std:c++20" --host_cxxopt="/std:c++20"
+
 
 # Enable symlinks and runfiles on Windows (enabled by default on other platforms).
 startup --windows_enable_symlinks

.clang-tidy

@@ -1,23 +1,38 @@
 Checks:            clang-*,
+                   -clang-analyzer-core.CallAndMessage,
                    -clang-analyzer-optin.portability.UnixAPI,
                    -clang-analyzer-unix.Malloc,
                    -clang-diagnostic-pragma-once-outside-header,
+                   -clang-diagnostic-builtin-macro-redefined,
                    cppcoreguidelines-pro-type-member-init,
                    cppcoreguidelines-pro-type-static-cast-downcast,
                    misc-*,
                    -misc-non-private-member-variables-in-classes,
+                   -misc-use-anonymous-namespace,
+                   -misc-const-correctness,
+                   -misc-include-cleaner,
+                   -misc-unused-parameters,
                    modernize-*,
                    -modernize-avoid-c-arrays,
                    -modernize-use-trailing-return-type,
+                   -modernize-return-braced-init-list,
+                   -modernize-use-default-member-init,
+                   -modernize-type-traits,
+                   -modernize-use-emplace,
                    llvm-include-order,
                    performance-*,
                    -performance-no-int-to-ptr,
+                   -performance-avoid-endl,
                    portability-*,
                    readability-*,
                    -readability-convert-member-functions-to-static,
                    -readability-function-cognitive-complexity,
                    -readability-magic-numbers,
                    -readability-make-member-function-const,
                    -readability-simplify-boolean-expr,
+                   -readability-identifier-length,
+                   -readability-container-data-pointer,
+                   -readability-redundant-casting,
+                   -readability-avoid-return-with-void-value,
 
 WarningsAsErrors:  '*'

.github/workflows/format.yml

@@ -31,6 +31,8 @@ on:
   schedule:
     - cron: '0 0 * * *'
 
+  workflow_dispatch:
+
 concurrency:
 
   group: ${{ github.head_ref || github.run_id }}-${{ github.workflow }}
@@ -41,7 +43,7 @@ jobs:
   addlicense:
     name: verify licenses
 
-    runs-on: ubuntu-20.04
+    runs-on: ubuntu-24.04-16core
 
     steps:
     - uses: actions/checkout@v2
@@ -61,7 +63,7 @@ jobs:
   buildifier:
     name: check format with buildifier
 
-    runs-on: ubuntu-20.04
+    runs-on: ubuntu-24.04-16core
 
     steps:
     - uses: actions/checkout@v2
@@ -99,73 +101,64 @@ jobs:
   clang_format:
     name: check format with clang-format
 
-    runs-on: ubuntu-20.04
+    runs-on: ubuntu-24.04-16core
 
     steps:
     - uses: actions/checkout@v2
 
     - name: Install dependencies (Linux)
-      run: sudo apt update -y && sudo apt install -y clang-format-12
+      run: sudo apt update -y && sudo apt install -y clang-format-18
 
     - name: Format (clang-format)
       run: |
-        find . -name "*.h" -o -name "*.cc" -o -name "*.proto" | grep -v ".pb." | xargs -n1 clang-format-12 -i
+        find . -name "*.h" -o -name "*.cc" -o -name "*.proto" | grep -v ".pb." | xargs -n1 clang-format-18 -i
         git diff --exit-code
 
   clang_tidy:
     name: check format with clang-tidy
 
-    runs-on: ubuntu-20.04
+    runs-on: ubuntu-24.04-16core
 
     steps:
     - uses: actions/checkout@v2
 
     - name: Install dependencies (Linux)
-      run: sudo apt update -y && sudo apt install -y clang-tidy-12 lld-12 && sudo ln -sf /usr/bin/lld-12 /usr/bin/lld
-
-    - name: Bazel cache
-      uses: PiotrSikora/cache@v2.1.7-with-skip-cache
+      run: sudo apt update -y && sudo apt install -y clang-tidy-18 lld-18 && sudo ln -sf /usr/bin/lld-18 /usr/bin/lld
+
+    - name: set cache name
+      id: vars
+      # The cache tag consists of the following parts:
+      # * clang-tidy- prefix
+      # * matrix.name, which separates the cache for each build type.
+      # * hash of WORKSPACE, .bazelrc, and .bazelversion, which is
+      #   purely to differentiate caches for substantial changes in bazel.
+      # * github.sha, which is the commit hash of the commit used to generate
+      #   the cache entry.
+      run: echo "CACHE_TAG=clang-tidy-${{ matrix.name }}-${{ hashFiles('WORKSPACE', '.bazelrc', '.bazelversion') }}" >> "$GITHUB_OUTPUT"
+
+    - name: bazel cache
+      uses: actions/cache/restore@v3
       with:
-        path: |
-          ~/.cache/bazel
-        key: clang_tidy-${{ hashFiles('WORKSPACE', '.bazelrc', '.bazelversion', 'bazel/dependencies.bzl', 'bazel/repositories.bzl', 'bazel/cargo/wasmsign/remote/crates.bzl') }}
+        path: /tmp/bazel/cache
+        key: ${{ steps.vars.outputs.CACHE_TAG }}-${{ github.sha }}
+        restore-keys: |
+          ${{ steps.vars.outputs.CACHE_TAG }}-${{ github.sha }}
+          ${{ steps.vars.outputs.CACHE_TAG }}-
+          clang-tidy-${{ matrix.name }}-
+          clang-tidy-
 
     - name: Bazel build
       run: >
         bazel build
         --config clang-tidy
         --define engine=multi
+        --disk_cache /tmp/bazel/cache
         --copt=-DPROXY_WASM_VERIFY_WITH_ED25519_PUBKEY=\"$(xxd -p -c 256 test/test_data/signature_key1.pub | cut -b9-)\"
         //...
 
-    - name: Skip Bazel cache update
-      if: ${{ github.ref != 'refs/heads/main' }}
-      run: echo "CACHE_SKIP_SAVE=true" >> $GITHUB_ENV
-
-    - name: Cleanup Bazel cache
-      if: ${{ github.ref == 'refs/heads/main' }}
-      run: |
-        export OUTPUT=$(${{ matrix.run_under }} bazel info output_base)
-        echo "===== BEFORE ====="
-        du -s ${OUTPUT}/external/* $(dirname ${OUTPUT})/* | sort -rn | head -20
-        # BoringSSL's test data (90 MiB).
-        rm -rf ${OUTPUT}/external/boringssl/crypto_test_data.cc
-        rm -rf ${OUTPUT}/external/boringssl/src/crypto/*/test/
-        rm -rf ${OUTPUT}/external/boringssl/src/third_party/wycheproof_testvectors/
-        # LLVM's tests (500 MiB).
-        rm -rf ${OUTPUT}/external/llvm*/test/
-        # V8's tests (100 MiB).
-        if [ -d "${OUTPUT}/external/v8/test/torque" ]; then
-          mv ${OUTPUT}/external/v8/test/torque ${OUTPUT}/external/v8/test_torque
-          rm -rf ${OUTPUT}/external/v8/test/*
-          mv ${OUTPUT}/external/v8/test_torque ${OUTPUT}/external/v8/test/torque
-        fi
-        # Unnecessary CMake tools (65 MiB).
-        rm -rf ${OUTPUT}/external/cmake-*/bin/{ccmake,cmake-gui,cpack,ctest}
-        # Distfiles for Rust toolchains (350 MiB).
-        rm -rf ${OUTPUT}/external/rust_*/*.tar.gz
-        # Bazel's repository cache (650-800 MiB) and install base (155 MiB).
-        rm -rf ${OUTPUT}/../cache
-        rm -rf ${OUTPUT}/../install
-        echo "===== AFTER ====="
-        du -s ${OUTPUT}/external/* $(dirname ${OUTPUT})/* | sort -rn | head -20
+    - name: save bazel cache
+      uses: actions/cache/save@v3
+      if: always()
+      with:
+        path: /tmp/bazel/cache
+        key: ${{ steps.vars.outputs.CACHE_TAG }}-${{ github.sha }}