Table and Table row visibility is not working. So fixed the issues. Review and let me know the pull request process

[umeshapt-finastra]

I have feature which should hide and show table and table rows based on a certain condition. I have made some code changes to support this feature in FONET git clone source. I would like to know how can I send you to pull request for review and approve. Attached updated files.

Changes in files under FLOW folder :

• AbstractTableBody.cs
• TableRow.cs
• Table.cs

And changes in files under Properties folder :

• VisibilityMaker.cs

Flow.zip
properties.zip

[cajuncoding]

I don't own the repo, but it's not clear why you would need to change the code here?

Based on your simple use case you could simply not render the Xml FO markup for the table and rows to be hidden, in your templating step -- if they aren't rendered then they won't be in the final output.

I run the templating step every time I want to render anything so that gives alot of flexibility and control to the process.

[umeshapt-finastra]

Hi Brandon, The changes has been made here for setting visibility for table and table rows. If visibility property is set to false, table or table-row shouldn't be rendered and they won't be in the final output. Otherwise table or table-row would be rendered. I have tested its working perfectly. Please let me know who is owning the repository. Regards, Umeshwaran.V

…

On Wed, Nov 13, 2019 at 10:04 PM Brandon ***@***.***> wrote: I don't own the repo, but why do you need to change the code here? Based on your simple use case you could simply not render the Xml FO markup for the table and rows to be hidden, in your templating step -- if they aren't rendered then they won't be in the final output. I run the templating step every time I want to render anything so that gives alot of flexibility and control to the process. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#3?email_source=notifications&email_token=ANX6RL2BNHZISRU7MXLNK6TQTQUCLA5CNFSM4JMB5AE2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOED6XWOA#issuecomment-553483064>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ANX6RLYKP6BL5SEYNDXFB3DQTQUCLANCNFSM4JMB5AEQ> .