IX adapter crashes when there is no interstitial size

[justadreamer]

Complaint

Mobile pubs sometimes report a crash on interstitial requests like:

500 error type: Critical error while running the auction: null

(talk to me in Prebid Slack I'll give you a curl)

Root cause analysis

formats is not null-checked here in the Index Exchange adapter:

prebid-server-java/src/main/java/org/prebid/server/bidder/ix/IxBidder.java

Line 154 in 01acd95

} else if (formats.size() == 1) {

and it causes a crash when there was no formats specified and no matching sizes were computed due to device.ext.prebid.interstitial.min[width/height]perc being too high or not specified. imp will be returned unaltered from here in either of those cases:

prebid-server-java/src/main/java/org/prebid/server/auction/InterstitialProcessor.java

Line 83 in 01acd95

return imp;

Fix options

1. implement a null check and a test case (but other adapters may have similar failures, thus see option 2)
2. ensure formats is always an array before sending it to bid adapters either empty or with at least one size (but which?)

[osulzhenko]

Hi @justadreamer, thanks for the note. Is this still relevant? Also, could you provide more info about this issue, the request, or other data? It should be processed by RequestValidator and ImpValidator with a proper response. I want to understand the root cause of the 500 error type: Critical error while running the auction: null before performing a simple check

[justadreamer]

hey @osulzhenko sent privately in Prebid Slack, thanks for looking into it.