Asterio Bid Adapter: Add native support#14929
Conversation
|
Tread carefully! This PR adds 8 linter errors (possibly disabled through directives):
|
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 669f6c14c4
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| bidId: bidRequest.bidId, | ||
| adUnitToken: bidRequest.params.adUnitToken, | ||
| pos: getPosition(bidRequest), | ||
| sizes: prepareSizes(bidRequest.sizes) | ||
| sizes: prepareSizes(getSizes(bidRequest)) | ||
| })); |
There was a problem hiding this comment.
Native support is declared, but the outbound bid payload only includes bidId, adUnitToken, pos, and sizes; it never forwards the ad unit’s native asset request (mediaTypes.native / ORTB native assets). In ORTB-native setups with custom asset IDs or required assets, the bidder cannot reliably match requested assets, which can cause returned native bids to fail core native validation and be dropped before auction completion.
Useful? React with 👍 / 👎.
| } else if (asset.data?.value && (asset.data.type === 2 || !native.body)) { | ||
| native.body = asset.data.value; |
There was a problem hiding this comment.
The body assignment currently falls back to the first data asset regardless of type via (asset.data.type === 2 || !native.body). If a non-description data asset (for example sponsored-by/type 1) appears first and no type-2 asset is present, native.body is populated with the wrong value, causing incorrect native content rendering.
Useful? React with 👍 / 👎.
1 participant
Type of change
Bugfix
Feature
New bidder adapter
Updated bidder adapter
Code style update (formatting, local variables)
Refactoring (no functional changes, no api changes)
Build related changes
CI related changes
Does this change affect user-facing APIs or examples documented on http://prebid.org?
Other
Description of change
Adds Native as a supported media type for the Asterio bid adapter.
The adapter continues to use
adUnitTokenas the only required bidder parameter. Native bid responses from Asterio are mapped into Prebid native fields so publishers can render native assets using standard Prebid native rendering flows.Documentation PR: prebid/prebid.github.io#6578