more tests for coverage

Author: funbringer

tests/test_simple.py

@@ -53,10 +53,11 @@ def test_custom_init(self):
 
     def test_double_init(self):
         with get_new_node('test') as node:
+            node.init()
+
             # can't initialize node more than once
             with self.assertRaises(InitNodeException):
                 node.init()
-                node.init()
 
     def test_init_after_cleanup(self):
         with get_new_node('test') as node:
@@ -70,6 +71,14 @@ def test_init_after_cleanup(self):
             node.status()
             node.safe_psql('postgres', 'select 1')
 
+    def test_double_start(self):
+        with get_new_node('test') as node:
+            node.init().start()
+
+            # can't start node more than once
+            with self.assertRaises(StartNodeException):
+                node.start()
+
     def test_uninitialized_start(self):
         with get_new_node('test') as node:
             # node is not initialized yet
@@ -119,22 +128,13 @@ def test_psql(self):
 
     def test_status(self):
         # check NodeStatus cast to bool
-        condition_triggered = False
-        if NodeStatus.Running:
-            condition_triggered = True
-        self.assertTrue(condition_triggered)
+        self.assertTrue(NodeStatus.Running)
 
         # check NodeStatus cast to bool
-        condition_triggered = False
-        if NodeStatus.Stopped:
-            condition_triggered = True
-        self.assertFalse(condition_triggered)
+        self.assertFalse(NodeStatus.Stopped)
 
         # check NodeStatus cast to bool
-        condition_triggered = False
-        if NodeStatus.Uninitialized:
-            condition_triggered = True
-        self.assertFalse(condition_triggered)
+        self.assertFalse(NodeStatus.Uninitialized)
 
         # check statuses after each operation
         with get_new_node('test') as node:
@@ -426,6 +426,10 @@ def test_logging(self):
                 lines = log.readlines()
                 self.assertTrue(any(node_name in s for s in lines))
 
+            # test logger after restart
+            master.restart()
+            self.assertTrue(master._logger.is_alive())
+
     def test_pgbench(self):
         with get_new_node('node') as node:
             node.init().start().pgbench_init()