File tree Expand file tree Collapse file tree 3 files changed +23
-14
lines changed
src/components/publications Expand file tree Collapse file tree 3 files changed +23
-14
lines changed Original file line number Diff line number Diff line change @@ -17,6 +17,12 @@ npm run dev
1717
1818Open [ http://localhost:3000 ] ( http://localhost:3000 ) in your browser to see the result!
1919
20+ To see issues that will prevent github from deploying, even though run dev won't fail:
21+
22+ ``` sh
23+ npm run build
24+ ```
25+
2026## Recommended Extensions
2127
2228If using VSCode, there are a few extensions that will help make the development experience smoother.
Original file line number Diff line number Diff line change @@ -88,19 +88,20 @@ const PublicationLinks: React.FC<Props> = (props) => {
8888 }
8989 case PublicationKind . Workshop : {
9090 const { pdfUrl } = props ;
91-
92- body = (
93- < a
94- href = { pdfUrl }
95- target = "_blank"
96- rel = "noopener noreferrer"
97- className = "stack-h stack-h-xs mt-2 items-center transition-opacity hover:opacity-75"
98- >
99- { ExternalLinkIcon }
100- < span className = "font-mono text-xs" > PDF</ span >
101- </ a >
102- ) ;
103- break ;
91+ if ( pdfUrl ) {
92+ body = (
93+ < a
94+ href = { pdfUrl }
95+ target = "_blank"
96+ rel = "noopener noreferrer"
97+ className = "stack-h stack-h-xs mt-2 items-center transition-opacity hover:opacity-75"
98+ >
99+ { ExternalLinkIcon }
100+ < span className = "font-mono text-xs" > PDF</ span >
101+ </ a >
102+ ) ;
103+ break ;
104+ }
104105 }
105106 }
106107
Original file line number Diff line number Diff line change @@ -13,7 +13,9 @@ const PublicationTitle: React.FC<React.PropsWithChildren<Props>> = (props) => {
1313 break ;
1414 case PublicationKind . Workshop :
1515 const { pdfUrl } = props ;
16- pdfHref = pdfUrl ;
16+ if ( pdfUrl ) {
17+ pdfHref = pdfUrl ;
18+ }
1719 break ;
1820 }
1921
You can’t perform that action at this time.
0 commit comments