Remove deprecated V8\Context::EstimatedSize() method

Author: pinepain

src/php_v8_context.cc

@@ -262,20 +262,6 @@ static PHP_METHOD(V8Context, SetErrorMessageForCodeGenerationFromStrings)
     context->SetErrorMessageForCodeGenerationFromStrings(local_string);
 }
 
-static PHP_METHOD(V8Context, EstimatedSize)
-{
-    if (zend_parse_parameters_none() == FAILURE) {
-        return;
-    }
-
-    PHP_V8_CONTEXT_FETCH_WITH_CHECK(getThis(), php_v8_context);
-
-    PHP_V8_ENTER_STORED_ISOLATE(php_v8_context);
-    PHP_V8_ENTER_CONTEXT(php_v8_context);
-
-    RETURN_LONG(context->EstimatedSize());
-}
-
 ZEND_BEGIN_ARG_INFO_EX(arginfo_v8_context___construct, ZEND_SEND_BY_VAL, ZEND_RETURN_VALUE, 1)
     ZEND_ARG_OBJ_INFO(0, isolate, V8\\Isolate, 0)
     ZEND_ARG_OBJ_INFO(0, global_template, V8\\ObjectTemplate, 1)
@@ -318,9 +304,6 @@ ZEND_BEGIN_ARG_INFO_EX(arginfo_v8_context_SetErrorMessageForCodeGenerationFromSt
                 ZEND_ARG_OBJ_INFO(0, message, V8\\StringValue, 0)
 ZEND_END_ARG_INFO()
 
-PHP_V8_ZEND_BEGIN_ARG_WITH_RETURN_TYPE_INFO_EX(arginfo_v8_context_EstimatedSize, ZEND_RETURN_VALUE, 0, IS_LONG, 0)
-ZEND_END_ARG_INFO()
-
 
 static const zend_function_entry php_v8_context_methods[] = {
     PHP_ME(V8Context, __construct, arginfo_v8_context___construct, ZEND_ACC_PUBLIC | ZEND_ACC_CTOR)
@@ -337,8 +320,6 @@ static const zend_function_entry php_v8_context_methods[] = {
     PHP_ME(V8Context, IsCodeGenerationFromStringsAllowed, arginfo_v8_context_IsCodeGenerationFromStringsAllowed, ZEND_ACC_PUBLIC)
     PHP_ME(V8Context, SetErrorMessageForCodeGenerationFromStrings, arginfo_v8_context_SetErrorMessageForCodeGenerationFromStrings, ZEND_ACC_PUBLIC)
 
-    PHP_ME(V8Context, EstimatedSize, arginfo_v8_context_EstimatedSize, ZEND_ACC_PUBLIC)
-
     PHP_FE_END
 };
 

stubs/src/Context.php

@@ -55,7 +55,7 @@ public function __construct(
     /**
      * @return \V8\Isolate
      */
-    public function GetIsolate() : Isolate
+    public function GetIsolate(): Isolate
     {
         return $this->isolate;
     }
@@ -74,7 +74,7 @@ public function GetIsolate() : Isolate
      *
      * @return \V8\ObjectValue
      */
-    public function GlobalObject() : ObjectValue
+    public function GlobalObject(): ObjectValue
     {
     }
 
@@ -110,7 +110,7 @@ public function UseDefaultSecurityToken()
      *
      * @return \V8\Value
      */
-    public function GetSecurityToken() : Value
+    public function GetSecurityToken(): Value
     {
     }
 
@@ -139,7 +139,7 @@ public function AllowCodeGenerationFromStrings(bool $allow)
      *
      * @return bool
      */
-    public function IsCodeGenerationFromStringsAllowed() : bool
+    public function IsCodeGenerationFromStringsAllowed(): bool
     {
     }
 
@@ -153,11 +153,4 @@ public function IsCodeGenerationFromStringsAllowed() : bool
     public function SetErrorMessageForCodeGenerationFromStrings(StringValue $message)
     {
     }
-
-    /**
-     * Estimate the memory in bytes retained by this context.
-     */
-    public function EstimatedSize() : int
-    {
-    }
 }

tests/V8Context.phpt

@@ -14,7 +14,6 @@ $v8_helper = new PhpV8Helpers($helper);
 $isolate1 = new \V8\Isolate();
 
 $context = new \V8\Context($isolate1);
-$helper->pretty_dump('Estimated memory usage size by this context', $context->EstimatedSize());
 
 $helper->method_matches_instanceof($context, 'GlobalObject', \V8\ObjectValue::class);
 
@@ -37,11 +36,9 @@ $res = $v8_helper->CompileTryRun($context, 'eval("1+1")');
 $context->SetErrorMessageForCodeGenerationFromStrings(new \V8\StringValue($isolate1, 'Whoa! Nope. No eval this time, sorry.'));
 $res = $v8_helper->CompileTryRun($context, 'eval("2+2")');
 
-$helper->pretty_dump('Estimated memory usage size by this context', $context->EstimatedSize());
 
 ?>
---EXPECTF--
-Estimated memory usage size by this context: int(%d)
+--EXPECT--
 V8\Context::GlobalObject() result is instance of V8\ObjectValue
 CHECK $global->SameValue($context->GlobalObject()): OK
 V8\Context::IsCodeGenerationFromStringsAllowed() matches expected value
@@ -50,4 +47,3 @@ Code generation is not allowed: ok
 V8\Context::IsCodeGenerationFromStringsAllowed() matches expected false
 eval("1+1"): V8\Exceptions\TryCatchException: EvalError: Code generation from strings disallowed for this context
 eval("2+2"): V8\Exceptions\TryCatchException: EvalError: Whoa! Nope. No eval this time, sorry.
-Estimated memory usage size by this context: int(%d)