Remove require $isolate parameter from V8\Value::TypeOf()

Only isolate that value belongs to can be used, so this parameter is redundant.

Author: pinepain

CMakeLists.txt

@@ -3,8 +3,8 @@ project(php_v8)
 
 # NOTE: This CMake file is just for syntax highlighting in CLion
 
-include_directories(/usr/local/opt/v8@5.9/include)
-include_directories(/usr/local/opt/v8@5.9/include/libplatform)
+include_directories(/usr/local/opt/v8@6.0/include)
+include_directories(/usr/local/opt/v8@6.0/include/libplatform)
 
 include_directories(/usr/local/include/php)
 include_directories(/usr/local/include/php/TSRM)

src/php_v8_value.cc

@@ -874,24 +874,19 @@ static PHP_METHOD(V8Value, SameValue) {
 }
 
 static PHP_METHOD(V8Value, TypeOf) {
-    zval *php_v8_isolate_zv;
-
-    if (zend_parse_parameters(ZEND_NUM_ARGS(), "o", &php_v8_isolate_zv) == FAILURE) {
+    if (zend_parse_parameters_none() == FAILURE) {
         return;
     }
 
-    PHP_V8_ISOLATE_FETCH_WITH_CHECK(php_v8_isolate_zv, php_v8_isolate);
     PHP_V8_VALUE_FETCH_WITH_CHECK(getThis(), php_v8_value);
 
-    PHP_V8_DATA_ISOLATES_CHECK_USING(php_v8_value, php_v8_isolate);
-
     PHP_V8_ENTER_STORED_ISOLATE(php_v8_value);
 
     v8::Local<v8::String> local_string = php_v8_value_get_local(php_v8_value)->TypeOf(isolate);
 
     PHP_V8_THROW_EXCEPTION_WHEN_EMPTY(local_string, "Failed to get type of value");
 
-    php_v8_get_or_create_value(return_value, local_string, php_v8_isolate);
+    php_v8_get_or_create_value(return_value, local_string, php_v8_value->php_v8_isolate);
 }
 
 
@@ -1029,7 +1024,6 @@ ZEND_BEGIN_ARG_INFO_EX(arginfo_v8_value_SameValue, ZEND_SEND_BY_VAL, ZEND_RETURN
 ZEND_END_ARG_INFO()
 
 PHP_V8_ZEND_BEGIN_ARG_WITH_RETURN_OBJ_INFO_EX(arginfo_v8_value_TypeOf, ZEND_RETURN_VALUE, 0, V8\\StringValue, 0)
-                ZEND_ARG_OBJ_INFO(0, isolate, V8\\Isolate, 0)
 ZEND_END_ARG_INFO()
 
 

stubs/src/Value.php

@@ -404,21 +404,12 @@ public function SameValue(Value $that)
     {
     }
 
-
-//    /**
-//     * @param Value $value
-//     * @return Value
-//     */
-////template <class T> V8_INLINE static Value* Cast(T* value);
-//    public static function Cast(Value $value) {}
-//  Local<String> TypeOf(v8::Isolate*);
-
     /**
-     * @param Isolate $isolate
-     *
      * @return StringValue
      */
-    public function TypeOf(Isolate $isolate) : StringValue
+    public function TypeOf() : StringValue
     {
     }
+
+    //public function
 }

tests/.v8-helpers.php

@@ -115,7 +115,7 @@ public function run_checks(\V8\Value $value, $title=null) {
 
         $filter = new ArrayListFilter(['TypeOf'], false);
         $finalizer = new CallChainFinalizer([\V8\StringValue::class => 'Value'], [], false);
-        $this->testsuite->dump_object_methods($value, ['@@default' => [$value->GetIsolate()]], $filter, $finalizer);
+        $this->testsuite->dump_object_methods($value, [], $filter, $finalizer);
         $this->testsuite->line();
 
         $filter = new RegexpFilter('/^Is/');

tests/V8Value.phpt

@@ -23,7 +23,7 @@ $helper->dump($value);
 $helper->space();
 
 $helper->assert('Value extends Data', $value instanceof \V8\Data);
-$helper->assert('TypeOf returns StringValue', $value->TypeOf($isolate) instanceof \V8\StringValue);
+$helper->assert('TypeOf returns StringValue', $value->TypeOf() instanceof \V8\StringValue);
 $helper->line();
 
 $helper->header('Accessors');