Setting boolean props on StackFrame with valid type

pinepain · pinepain · commit b586e7066f62 · 2017-04-22T18:18:34.000+03:00
diff --git a/src/php_v8_stack_frame.cc b/src/php_v8_stack_frame.cc
@@ -62,11 +62,10 @@ void php_v8_stack_frame_create_from_stack_frame(zval *return_value, v8::Local<v8
     }
 
     /* v8::StackFrame::IsEval */
-    zend_update_property_long(this_ce, return_value, ZEND_STRL("is_eval"), static_cast<zend_bool >(frame->IsEval()));
+    zend_update_property_bool(this_ce, return_value, ZEND_STRL("is_eval"), static_cast<zend_bool >(frame->IsEval()));
 
     /* v8::StackFrame::IsConstructor */
-    zend_update_property_long(this_ce, return_value, ZEND_STRL("is_constructor"),
-                              static_cast<zend_bool >(frame->IsConstructor()));
+    zend_update_property_bool(this_ce, return_value, ZEND_STRL("is_constructor"), static_cast<zend_bool >(frame->IsConstructor()));
 }
 
 static PHP_METHOD(V8StackFrame, __construct) {
diff --git a/tests/V8Exception_GetStackTrace.phpt b/tests/V8Exception_GetStackTrace.phpt
@@ -126,9 +126,9 @@ V8\StackTrace->getFrames():
         ["function_name":"V8\StackFrame":private]=>
         string(0) ""
         ["is_eval":"V8\StackFrame":private]=>
-        int(0)
+        bool(false)
         ["is_constructor":"V8\StackFrame":private]=>
-        int(0)
+        bool(false)
       }
     }
 V8\StackTrace->GetFrameCount(): int(1)

Original file line number	Diff line number	Diff line change
`@@ -62,11 +62,10 @@ void php_v8_stack_frame_create_from_stack_frame(zval *return_value, v8::Local<v8`
`62`	`62`	`}`
`63`	`63`
`64`	`64`	`/* v8::StackFrame::IsEval */`
`65`		`- zend_update_property_long(this_ce, return_value, ZEND_STRL("is_eval"), static_cast<zend_bool >(frame->IsEval()));`
	`65`	`+ zend_update_property_bool(this_ce, return_value, ZEND_STRL("is_eval"), static_cast<zend_bool >(frame->IsEval()));`
`66`	`66`
`67`	`67`	`/* v8::StackFrame::IsConstructor */`
`68`		`- zend_update_property_long(this_ce, return_value, ZEND_STRL("is_constructor"),`
`69`		`- static_cast<zend_bool >(frame->IsConstructor()));`
	`68`	`+ zend_update_property_bool(this_ce, return_value, ZEND_STRL("is_constructor"), static_cast<zend_bool >(frame->IsConstructor()));`
`70`	`69`	`}`
`71`	`70`
`72`	`71`	`static PHP_METHOD(V8StackFrame, __construct) {`
Original file line number	Diff line number	Diff line change
`@@ -126,9 +126,9 @@ V8\StackTrace->getFrames():`
`126`	`126`	`["function_name":"V8\StackFrame":private]=>`
`127`	`127`	`string(0) ""`
`128`	`128`	`["is_eval":"V8\StackFrame":private]=>`
`129`		`- int(0)`
	`129`	`+ bool(false)`
`130`	`130`	`["is_constructor":"V8\StackFrame":private]=>`
`131`		`- int(0)`
	`131`	`+ bool(false)`
`132`	`132`	`}`
`133`	`133`	`}`
`134`	`134`	`V8\StackTrace->GetFrameCount(): int(1)`