Make V8\Isolate::ThrowException() method void

Internally it always returns an undefined value, so return result in userland is useless

Author: pinepain

src/php_v8_isolate.cc

@@ -396,10 +396,8 @@ static PHP_METHOD(V8Isolate, ThrowException) {
     PHP_V8_ENTER_CONTEXT(php_v8_context);
 
     v8::Local<v8::Value> local_value = php_v8_value_get_local(php_v8_value);
-    v8::Local<v8::Value> local_return_value = isolate->ThrowException(local_value);
 
-    /* From v8 source code, Isolate::ThrowException() returns v8::Undefined() */
-    php_v8_get_or_create_value(return_value, local_return_value, php_v8_value->php_v8_isolate);
+    isolate->ThrowException(local_value);
 }
 
 static PHP_METHOD(V8Isolate, IdleNotificationDeadline) {
@@ -552,7 +550,7 @@ ZEND_END_ARG_INFO()
 PHP_V8_ZEND_BEGIN_ARG_WITH_RETURN_OBJ_INFO_EX(arginfo_v8_isolate_GetEnteredContext, ZEND_RETURN_VALUE, 0, V8\\Context, 0)
 ZEND_END_ARG_INFO()
 
-PHP_V8_ZEND_BEGIN_ARG_WITH_RETURN_OBJ_INFO_EX(arginfo_v8_isolate_ThrowException, ZEND_RETURN_VALUE, 2, V8\\Value, 0)
+ZEND_BEGIN_ARG_INFO_EX(arginfo_v8_isolate_ThrowException, ZEND_SEND_BY_VAL, ZEND_RETURN_VALUE, 2)
                 ZEND_ARG_OBJ_INFO(0, context, V8\\Context, 0)
                 ZEND_ARG_OBJ_INFO(0, value, V8\\Value, 0)
 ZEND_END_ARG_INFO()

stubs/src/Isolate.php

@@ -98,9 +98,9 @@ public function GetEnteredContext(): Context
      * @param Context $context
      * @param Value   $value
      *
-     * @return Value
+     * @return void
      */
-    public function ThrowException(Context $context, Value $value): Value
+    public function ThrowException(Context $context, Value $value)
     {
     }
 

tests/V8Exception_Error.phpt

@@ -24,9 +24,7 @@ $helper->line();
 $func_tpl = new \V8\FunctionTemplate($isolate, function (\V8\FunctionCallbackInfo $info) {
     $value = count($info->Arguments()) ? $info->Arguments()[0] : new \V8\StringValue($info->GetIsolate(), "exception");
 
-    $e = $info->GetIsolate()->ThrowException($info->GetContext(), V8\Exception::Error($info->GetContext(), $value));
-
-    $info->GetReturnValue()->Set($e);
+    $info->GetIsolate()->ThrowException($info->GetContext(), V8\Exception::Error($info->GetContext(), $value));
 });
 
 $func_test_tpl = new \V8\FunctionTemplate($isolate, function (\V8\FunctionCallbackInfo $info) use ($helper, $v8_helper) {

tests/V8Exception_RangeError.phpt

@@ -25,9 +25,7 @@ $helper->line();
 $func_tpl = new \V8\FunctionTemplate($isolate, function (\V8\FunctionCallbackInfo $info) {
     $value = count($info->Arguments()) ? $info->Arguments()[0] : new \V8\StringValue($info->GetIsolate(), "exception");
 
-    $e = $info->GetIsolate()->ThrowException($info->GetContext(), V8\Exception::RangeError($info->GetContext(), $value));
-
-    $info->GetReturnValue()->Set($e);
+    $info->GetIsolate()->ThrowException($info->GetContext(), V8\Exception::RangeError($info->GetContext(), $value));
 });
 
 $func_test_tpl = new \V8\FunctionTemplate($isolate, function (\V8\FunctionCallbackInfo $info) use ($helper, $v8_helper) {

tests/V8Exception_ReferenceError.phpt

@@ -25,9 +25,7 @@ $helper->line();
 $func_tpl = new \V8\FunctionTemplate($isolate, function (\V8\FunctionCallbackInfo $info) {
     $value = count($info->Arguments()) ? $info->Arguments()[0] : new \V8\StringValue($info->GetIsolate(), "exception");
 
-    $e = $info->GetIsolate()->ThrowException($info->GetContext(), V8\Exception::ReferenceError($info->GetContext(), $value));
-
-    $info->GetReturnValue()->Set($e);
+    $info->GetIsolate()->ThrowException($info->GetContext(), V8\Exception::ReferenceError($info->GetContext(), $value));
 });
 
 $func_test_tpl = new \V8\FunctionTemplate($isolate, function (\V8\FunctionCallbackInfo $info) use ($helper, $v8_helper) {

tests/V8Exception_SyntaxError.phpt

@@ -25,9 +25,7 @@ $helper->line();
 $func_tpl = new \V8\FunctionTemplate($isolate, function (\V8\FunctionCallbackInfo $info) {
     $value = count($info->Arguments()) ? $info->Arguments()[0] : new \V8\StringValue($info->GetIsolate(), "exception");
 
-    $e = $info->GetIsolate()->ThrowException($info->GetContext(), V8\Exception::SyntaxError($info->GetContext(), $value));
-
-    $info->GetReturnValue()->Set($e);
+    $info->GetIsolate()->ThrowException($info->GetContext(), V8\Exception::SyntaxError($info->GetContext(), $value));
 });
 
 $func_test_tpl = new \V8\FunctionTemplate($isolate, function (\V8\FunctionCallbackInfo $info) use ($helper, $v8_helper) {

tests/V8Exception_TypeError.phpt

@@ -25,9 +25,7 @@ $helper->line();
 $func_tpl = new \V8\FunctionTemplate($isolate, function (\V8\FunctionCallbackInfo $info) {
     $value = count($info->Arguments()) ? $info->Arguments()[0] : new \V8\StringValue($info->GetIsolate(), "exception");
 
-    $e = $info->GetIsolate()->ThrowException($info->GetContext(), V8\Exception::TypeError($info->GetContext(), $value));
-
-    $info->GetReturnValue()->Set($e);
+    $info->GetIsolate()->ThrowException($info->GetContext(), V8\Exception::TypeError($info->GetContext(), $value));
 });
 
 $func_test_tpl = new \V8\FunctionTemplate($isolate, function (\V8\FunctionCallbackInfo $info) use ($helper, $v8_helper) {

tests/V8Isolate_ThrowException.phpt

@@ -16,9 +16,7 @@ $isolate = new \V8\Isolate();
 $func_tpl = new \V8\FunctionTemplate($isolate, function (\V8\FunctionCallbackInfo $info) {
     $value = count($info->Arguments()) ? $info->Arguments()[0] : new \V8\StringValue($info->GetIsolate(), "exception");
 
-    $e = $info->GetIsolate()->ThrowException($info->GetContext(), $value);
-
-    $info->GetReturnValue()->Set($e);
+    $info->GetIsolate()->ThrowException($info->GetContext(), $value);
 });