Using `#[Required]` on traits won't be recognized correctly since v2.0.11

[mvhirsch]

Hi,

PHPStan rly helps me fixing bugs in my code. I'm always eager to update it! However, the latest phpstan-symfony extensions seems to introduce a bug when using #[Required] on traits:

Class HelloWorld has an uninitialized readonly property $query. Assign it in the constructor.

Reproducible

https://phpstan.org/r/f7e42743-2ab6-44cc-ad55-ffae9b30dcc0

<?php

use Symfony\Contracts\Service\Attribute\Required;

interface MyQueryInterface {
    public function execute(): array;
}

trait GenreFetcherTrait
{
    private readonly MyQueryInterface $query; 

    protected function dosomething(): array
    {
        return $this->query->execute();
    }

    #[Required]
    public function setQuery(MyQueryInterface $query): void {
        $this->query = $query;
    }
}


class HelloWorld
{
    use GenreFetcherTrait;
}

Expected results

No issues. Used to work with v2.0.10.

[mickverm]

I have the same issue, the temporary solution is to remove readonly from the property.

It's caused by 32f0013

[ondrejmirtes]

Fixed: 53e2128

Will release 2.0.12 in a few moments.

[mickverm]

@ondrejmirtes The test case has private MyQueryInterface $query; instead of private readonly MyQueryInterface $query;, so it basically tests the case that was already working.

phpstan-symfony/tests/Symfony/data/bug-468.php

Line 13 in 53e2128

private MyQueryInterface $query;

[ondrejmirtes]

Yes, but it should be fixed anyway. With readonly I'd have to create a separate testcase for a different rule, but the fix in src/ would still be the same.

[mickverm]

Thank you for the clarification 👍

[ondrejmirtes]

The difference with readonly is that PHPStan always reports it when uninitialized. Without readonly you have to turn on checkUninitializedProperties: true.

[mickverm]

I can confirm that it's fixed, thank you for the quick intervention.

[mvhirsch]

Thank you very much! Renovate Bot merged v2.0.12 during my lunch break ❤️