Loosing narrowed type on `Symfony\Contracts\Cache\CacheInterface`

[mvhirsch]

Bug report

I'm passing a non-negative-int in my method, which is correctly detected by PHPStan. However, it looses it's narrowed type on the way passing through CacheInterface. I'm not sure why.

I created a reproducer repo, as I'm unable to reproduce this issue on Playground.

https://github.com/mvhirsch/phpstan-symfony-cache-reproducer

Code snippet that reproduces the problem

No response

Expected output

No issues. Return type of $this->cache->get() should be int<0, max>, not int.

Did PHPStan help you today? Did it make you happy in any way?

It helps me keeping calm and settled in a hasty project.

[mvhirsch]

ping @silasjoisten

[mergeable]

This bug report is missing a link to reproduction at phpstan.org/try.

It will most likely be closed after manual review.

[ondrejmirtes]

This is a problem with phpstan-symfony. Without it it works properly: https://phpstan.org/r/56797d1e-5328-4d0f-b723-224a8058c3fb

[ondrejmirtes]

This stub probably needs to be updated https://github.com/phpstan/phpstan-symfony/blob/2.0.x/stubs/Symfony/Contracts/Cache/CacheInterface.stub

[mvhirsch]

Like this?

https://github.com/symfony/symfony/blob/b49a855dcfc018f496edec2cf1606629639461a8/src/Symfony/Contracts/Cache/CacheInterface.php#L35

[ondrejmirtes]

Not sure, try sending a PR with a test :)

[astehlik]

I did some testing here and it seems the problem is caused by the \PHPStan\Type\Symfony\CacheInterfaceGetDynamicReturnTypeExtension, especially the generalize() call here.

I'm not sure, if this is needed any more because PHPStan seems to detect the type from the callback automatically (even without the Synfony Extension installed).