locateIdentifiersByType returns all located classes or functions

Author: tomasfejfar

src/Reflection/BetterReflection/SourceLocator/OptimizedDirectorySourceLocator.php

@@ -246,9 +246,57 @@ private function findSymbols(string $file): array
 		];
 	}
 
+	/**
+	 * @return array<int, Reflection>
+	 */
 	public function locateIdentifiersByType(Reflector $reflector, IdentifierType $identifierType): array
 	{
-		return [];
+		if ($this->classToFile === null || $this->functionToFiles === null) {
+			$this->init();
+			if ($this->classToFile === null || $this->functionToFiles === null) {
+				throw new ShouldNotHappenException();
+			}
+		}
+
+		$reflections = [];
+		if ($identifierType->isClass()) {
+			foreach ($this->classToFile as $className => $file) {
+				if (array_key_exists($className, $this->classNodes)) {
+					$reflections[$className] = $this->nodeToReflection($reflector, $this->classNodes[$className]);
+					continue;
+				}
+
+				$fetchedNodesResult = $this->fileNodesFetcher->fetchNodes($file);
+				foreach ($fetchedNodesResult->getClassNodes() as $identifierName => $fetchedClassNodes) {
+					foreach ($fetchedClassNodes as $fetchedClassNode) {
+						$this->classNodes[$identifierName] = $fetchedClassNode;
+						$reflections[$identifierName] = $this->nodeToReflection($reflector, $fetchedClassNode);
+						continue;
+					}
+				}
+			}
+		} elseif ($identifierType->isFunction()) {
+			foreach ($this->functionToFiles as $functionName => $files) {
+				foreach ($files as $file) {
+					if (array_key_exists($functionName, $this->functionNodes)) {
+						$reflections[$functionName] = $this->nodeToReflection(
+							$reflector,
+							$this->functionNodes[$functionName]
+						);
+						continue;
+					}
+
+					$fetchedNodesResult = $this->fileNodesFetcher->fetchNodes($file);
+					foreach ($fetchedNodesResult->getFunctionNodes() as $identifierName => $fetchedFunctionNode) {
+						$this->functionNodes[$identifierName] = $fetchedFunctionNode;
+						$reflections[$identifierName] = $this->nodeToReflection($reflector, $fetchedFunctionNode);
+						continue;
+					}
+				}
+			}
+		}
+
+		return array_values($reflections);
 	}
 
 }

tests/PHPStan/Reflection/BetterReflection/SourceLocator/OptimizedDirectorySourceLocatorTest.php

@@ -3,10 +3,13 @@
 namespace PHPStan\Reflection\BetterReflection\SourceLocator;
 
 use OptimizedDirectory\BFoo;
+use PHPStan\BetterReflection\Identifier\IdentifierType;
+use PHPStan\BetterReflection\Reflection\Reflection;
 use PHPStan\BetterReflection\Reflector\DefaultReflector;
 use PHPStan\BetterReflection\Reflector\Exception\IdentifierNotFound;
 use PHPStan\Testing\PHPStanTestCase;
 use TestDirectorySourceLocator\AFoo;
+use function array_map;
 use function basename;
 use const PHP_VERSION_ID;
 
@@ -135,6 +138,49 @@ public function testFunctionExists(string $functionName, string $expectedFunctio
 		$this->assertSame($file, basename($functionReflection->getFileName()));
 	}
 
+	public function testLocateIdentifiersByType(): void
+	{
+		/** @var OptimizedDirectorySourceLocatorFactory $factory */
+		$factory = self::getContainer()->getByType(OptimizedDirectorySourceLocatorFactory::class);
+		$locator = $factory->createByDirectory(__DIR__ . '/data/directory');
+		$reflector = new DefaultReflector($locator);
+
+		$classIdentifiers = $locator->locateIdentifiersByType(
+			$reflector,
+			new IdentifierType(IdentifierType::IDENTIFIER_CLASS),
+		);
+
+		$expectedClasses = [
+			'TestDirectorySourceLocator\AFoo',
+			'OptimizedDirectory\BFoo',
+			'CFoo',
+		];
+		if (PHP_VERSION_ID >= 80100) {
+			$expectedClasses[] = 'OptimizedDirectory\TestEnum';
+			$expectedClasses[] = 'OptimizedDirectory\BackedByStringWithoutSpace';
+			$expectedClasses[] = 'OptimizedDirectory\UppercaseEnum';
+		}
+
+		$actualClasses = array_map(static fn (Reflection $reflection) => $reflection->getName(), $classIdentifiers);
+		$this->assertEqualsCanonicalizing($expectedClasses, $actualClasses);
+
+		$functionIdentifiers = $locator->locateIdentifiersByType(
+			$reflector,
+			new IdentifierType(IdentifierType::IDENTIFIER_FUNCTION),
+		);
+
+		$actualFunctions = array_map(static fn (Reflection $reflection) => $reflection->getName(), $functionIdentifiers);
+
+		$this->assertEqualsCanonicalizing([
+			'TestDirectorySourceLocator\doLorem',
+			'OptimizedDirectory\doBar',
+			'OptimizedDirectory\doBaz',
+			'OptimizedDirectory\get_smarty',
+			'OptimizedDirectory\get_smarty2',
+			'OptimizedDirectory\upperCaseFunction',
+		], $actualFunctions);
+	}
+
 	public function dataFunctionDoesNotExist(): array
 	{
 		return [