Configure request object normalizer

Author: tatevikg1

config/services/normalizers.yml

@@ -15,5 +15,11 @@ services:
       $classMetadataFactory: '@?serializer.mapping.class_metadata_factory'
       $nameConverter: '@Symfony\Component\Serializer\NameConverter\CamelCaseToSnakeCaseNameConverter'
 
+  phplist.request_serializer:
+    class: Symfony\Component\Serializer\Serializer
+    arguments:
+      $normalizers:
+        - '@Symfony\Component\Serializer\Normalizer\ObjectNormalizer'
+
   PhpList\RestBundle\:
     resource: '../../src/*/Serializer/*'

config/services/validators.yml

@@ -1,7 +1,7 @@
 services:
   PhpList\RestBundle\Common\Validator\RequestValidator:
     arguments:
-      $serializer: '@Symfony\Component\Serializer\Normalizer\ObjectNormalizer'
+      $serializer: '@phplist.request_serializer'
       $validator: '@validator'
 
   PhpList\RestBundle\Identity\Validator\Constraint\UniqueEmailValidator:
@@ -50,4 +50,3 @@ services:
     autowire: true
     autoconfigure: true
     tags: [ 'validator.constraint_validator' ]
-

src/Common/EventListener/ExceptionListener.php

@@ -16,6 +16,8 @@
 use Symfony\Component\HttpKernel\Exception\AccessDeniedHttpException;
 use Symfony\Component\HttpKernel\Exception\HttpExceptionInterface;
 use Symfony\Component\Security\Core\Exception\AccessDeniedException;
+use Symfony\Component\Validator\ConstraintViolationInterface;
+use Symfony\Component\Validator\Exception\ValidationFailedException;
 use Symfony\Component\Validator\Exception\ValidatorException;
 
 class ExceptionListener
@@ -36,33 +38,107 @@ public function onKernelException(ExceptionEvent $event): void
     {
         $exception = $event->getThrowable();
 
+        if ($exception instanceof ValidationFailedException) {
+            $event->setResponse(
+                new JsonResponse([
+                    'message' => 'Validation failed',
+                    'errors' => $this->parseFlatValidationMessage($exception->getMessage()),
+                    ], 422)
+            );
+
+            return;
+        }
+
         foreach (self::EXCEPTION_STATUS_MAP as $class => $statusCode) {
             if ($exception instanceof $class) {
-                $status = $statusCode ?? $exception->getStatusCode();
+                $status = $statusCode ?? (
+                method_exists($exception, 'getStatusCode')
+                    ? $exception->getStatusCode()
+                    : 400
+                );
+
                 $event->setResponse(
                     new JsonResponse([
-                        'message' => $exception->getMessage()
+                        'message' => $exception->getMessage(),
+                        'errors' => $this->parseFlatValidationMessage($exception->getMessage()),
                     ], $status)
                 );
+
                 return;
             }
         }
 
         if ($exception instanceof HttpExceptionInterface) {
             $event->setResponse(
                 new JsonResponse([
-                    'message' => $exception->getMessage()
+                    'message' => $exception->getMessage(),
+                    'errors' => $this->parseFlatValidationMessage($exception->getMessage()),
                 ], $exception->getStatusCode())
             );
+
             return;
         }
 
         if ($exception instanceof Exception) {
             $event->setResponse(
                 new JsonResponse([
-                    'message' => $exception->getMessage()
+                    'message' => $exception->getMessage(),
+                    'errors' => $this->parseFlatValidationMessage($exception->getMessage()),
                 ], 500)
             );
         }
     }
+
+    /**
+     * @return array<string, array<int, string>>
+     */
+    private function formatViolations(ValidationFailedException $exception): array
+    {
+        $errors = [];
+
+        foreach ($exception->getViolations() as $violation) {
+            /** @var ConstraintViolationInterface $violation */
+            $field = $violation->getPropertyPath();
+            $message = $violation->getMessage();
+
+            if ($field === '') {
+                $field = '_global';
+            }
+
+            $errors[$field][] = $message;
+        }
+
+        return $errors;
+    }
+
+    /**
+     * @return array<string, array<int, string>>
+     */
+    private function parseFlatValidationMessage(string $message): array
+    {
+        $errors = [];
+        $lines = preg_split('/\r\n|\r|\n/', $message) ?: [];
+
+        foreach ($lines as $line) {
+            $line = trim($line);
+
+            if ($line === '') {
+                continue;
+            }
+
+            $parts = explode(':', $line, 2);
+
+            if (count($parts) !== 2) {
+                $errors['_global'][] = $line;
+                continue;
+            }
+
+            $field = trim($parts[0]);
+            $errorMessage = trim($parts[1]);
+
+            $errors[$field][] = $errorMessage;
+        }
+
+        return $errors;
+    }
 }

src/Messaging/Request/CreateMessageRequest.php

@@ -38,7 +38,7 @@ class CreateMessageRequest implements RequestInterface
     public MessageOptionsRequest $options;
 
     #[TemplateExists]
-    public ?int $templateId;
+    public ?int $templateId = null;
 
     public function getDto(): MessageDtoInterface
     {