Skip to content

Commit 64e7429

Browse files
committed
There is no need to use from_dict() during construction
This one was caught by the linter complaining that we aren't meant to be passing a list. Removing the use of from_dict and calling the default dataframe constructor removes the warnings.
1 parent 7f0a33c commit 64e7429

File tree

4 files changed

+4
-4
lines changed

4 files changed

+4
-4
lines changed

pynch/ame_mass_parse.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -52,4 +52,4 @@ def read_file(self) -> pd.DataFrame:
5252
# Remove the header lines
5353
lines = lines[self.HEADER : self.FOOTER]
5454

55-
return pd.DataFrame.from_dict([self._read_line(line) for line in lines])
55+
return pd.DataFrame([self._read_line(line) for line in lines])

pynch/ame_reaction_1_parse.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -58,4 +58,4 @@ def read_file(self) -> pd.DataFrame:
5858
# Remove the header lines
5959
lines = lines[self.HEADER : self.FOOTER]
6060

61-
return pd.DataFrame.from_dict([self._read_line(line) for line in lines])
61+
return pd.DataFrame([self._read_line(line) for line in lines])

pynch/ame_reaction_2_parse.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -61,4 +61,4 @@ def read_file(self) -> pd.DataFrame:
6161
# The 2020 rct2 file has additional lines feeds not present in any other file
6262
the_lines = [line for line in lines if line[:1] != "1"]
6363

64-
return pd.DataFrame.from_dict([self._read_line(line) for line in the_lines])
64+
return pd.DataFrame([self._read_line(line) for line in the_lines])

pynch/nubase_parse.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -131,4 +131,4 @@ def read_file(self) -> pd.DataFrame:
131131
self._read_line(line) for line in lines if self._readable_line(line)
132132
]
133133

134-
return pd.DataFrame.from_dict([d for d in the_lines if d])
134+
return pd.DataFrame([d for d in the_lines if d])

0 commit comments

Comments
 (0)