chore: enable ambiguous-function-call rule, and make all call sites explicit (#706)

azjezz · web-flow · commit 2357105dbb8b · 2026-03-20T09:02:33.000+01:00
diff --git a/src/Psl/Encoding/Base64/DecodingReadHandle.php b/src/Psl/Encoding/Base64/DecodingReadHandle.php
@@ -262,7 +262,7 @@ private function fillBuffer(CancellationTokenInterface $cancellation = new NullC
             $this->eof = true;
             // Decode any remaining bytes.
             if ($this->remainder !== '') {
-                $this->buffer .= decode($this->remainder, $this->variant, $this->padding);
+                $this->buffer .= namespace\decode($this->remainder, $this->variant, $this->padding);
                 $this->remainder = '';
             }
 
@@ -279,7 +279,7 @@ private function fillBuffer(CancellationTokenInterface $cancellation = new NullC
         $usable = $length - ($length % 4);
 
         if ($usable > 0) {
-            $this->buffer .= decode(substr($data, 0, $usable), $this->variant, $this->padding);
+            $this->buffer .= namespace\decode(substr($data, 0, $usable), $this->variant, $this->padding);
             $this->remainder = substr($data, $usable);
         } else {
             $this->remainder = $data;
diff --git a/src/Psl/Encoding/Base64/DecodingWriteHandle.php b/src/Psl/Encoding/Base64/DecodingWriteHandle.php
@@ -44,7 +44,7 @@ public function tryWrite(string $bytes): int
         $usable = $dataLength - ($dataLength % 4);
 
         if ($usable > 0) {
-            $decoded = decode(substr($data, 0, $usable), $this->variant, $this->padding);
+            $decoded = namespace\decode(substr($data, 0, $usable), $this->variant, $this->padding);
             $this->handle->writeAll($decoded);
             $this->remainder = substr($data, $usable);
         } else {
@@ -70,7 +70,7 @@ public function write(string $bytes, CancellationTokenInterface $cancellation =
     public function flush(): void
     {
         if ($this->remainder !== '') {
-            $decoded = decode($this->remainder, $this->variant, $this->padding);
+            $decoded = namespace\decode($this->remainder, $this->variant, $this->padding);
             $this->remainder = '';
             $this->handle->writeAll($decoded);
         }
diff --git a/src/Psl/Encoding/Base64/EncodingReadHandle.php b/src/Psl/Encoding/Base64/EncodingReadHandle.php
@@ -258,14 +258,14 @@ private function fillBuffer(CancellationTokenInterface $cancellation = new NullC
             // @codeCoverageIgnoreEnd
         }
 
-        $chunk = $this->handle->read(CHUNK_SIZE, $cancellation);
+        $chunk = $this->handle->read(namespace\CHUNK_SIZE, $cancellation);
         if ($chunk === '' && $this->handle->reachedEndOfDataSource()) {
             $this->eof = true;
             return;
         }
 
         if ($chunk !== '') {
-            $this->buffer .= encode($chunk, $this->variant, $this->padding) . LINE_ENDING;
+            $this->buffer .= namespace\encode($chunk, $this->variant, $this->padding) . namespace\LINE_ENDING;
         }
     }
 }
diff --git a/src/Psl/Encoding/Base64/EncodingWriteHandle.php b/src/Psl/Encoding/Base64/EncodingWriteHandle.php
@@ -36,12 +36,12 @@ public function tryWrite(string $bytes): int
         $data = $this->remainder . $bytes;
 
         $dataLength = strlen($data);
-        while ($dataLength >= CHUNK_SIZE) {
-            $chunk = substr($data, 0, CHUNK_SIZE);
-            $data = substr($data, CHUNK_SIZE);
-            $dataLength -= CHUNK_SIZE;
+        while ($dataLength >= namespace\CHUNK_SIZE) {
+            $chunk = substr($data, 0, namespace\CHUNK_SIZE);
+            $data = substr($data, namespace\CHUNK_SIZE);
+            $dataLength -= namespace\CHUNK_SIZE;
 
-            $encoded = encode($chunk, $this->variant, $this->padding) . LINE_ENDING;
+            $encoded = namespace\encode($chunk, $this->variant, $this->padding) . namespace\LINE_ENDING;
             $this->handle->writeAll($encoded);
         }
 
@@ -63,7 +63,7 @@ public function write(string $bytes, CancellationTokenInterface $cancellation =
     public function flush(): void
     {
         if ($this->remainder !== '') {
-            $encoded = encode($this->remainder, $this->variant, $this->padding) . LINE_ENDING;
+            $encoded = namespace\encode($this->remainder, $this->variant, $this->padding) . namespace\LINE_ENDING;
             $this->remainder = '';
             $this->handle->writeAll($encoded);
         }
diff --git a/src/Psl/Encoding/EncodedWord/Internal/decode_payload.php b/src/Psl/Encoding/EncodedWord/Internal/decode_payload.php
@@ -31,7 +31,7 @@ function decode_payload(string $encoding, string $text): string
     }
 
     if ($encoding === EncodedWord\Q_ENCODING) {
-        return q_decode($text);
+        return namespace\q_decode($text);
     }
 
     // @codeCoverageIgnoreStart
diff --git a/src/Psl/Encoding/EncodedWord/Internal/encode_q_words.php b/src/Psl/Encoding/EncodedWord/Internal/encode_q_words.php
@@ -21,7 +21,7 @@ function encode_q_words(string $text, string $prefix, string $suffix, int $maxPa
 
     for ($i = 0; $i < $len; $i++) {
         $byte = $text[$i];
-        $encoded = q_encode_byte($byte);
+        $encoded = namespace\q_encode_byte($byte);
         $encodedLen = strlen($encoded);
 
         // @codeCoverageIgnoreStart
diff --git a/src/Psl/Encoding/Hex/DecodingReadHandle.php b/src/Psl/Encoding/Hex/DecodingReadHandle.php
@@ -261,7 +261,7 @@ private function fillBuffer(CancellationTokenInterface $cancellation = new NullC
             // Decode any remaining bytes.
             if ($this->remainder !== '') {
                 // @codeCoverageIgnoreStart
-                $this->buffer .= decode($this->remainder);
+                $this->buffer .= namespace\decode($this->remainder);
                 $this->remainder = '';
                 // @codeCoverageIgnoreEnd
             }
@@ -276,7 +276,7 @@ private function fillBuffer(CancellationTokenInterface $cancellation = new NullC
         $usable = $length - ($length % 2);
 
         if ($usable > 0) {
-            $this->buffer .= decode(substr($data, 0, $usable));
+            $this->buffer .= namespace\decode(substr($data, 0, $usable));
             $this->remainder = substr($data, $usable);
         } else {
             // @codeCoverageIgnoreStart
diff --git a/src/Psl/Encoding/Hex/DecodingWriteHandle.php b/src/Psl/Encoding/Hex/DecodingWriteHandle.php
@@ -39,7 +39,7 @@ public function tryWrite(string $bytes): int
         $usable = $dataLength - ($dataLength % 2);
 
         if ($usable > 0) {
-            $decoded = decode(substr($data, 0, $usable));
+            $decoded = namespace\decode(substr($data, 0, $usable));
             $this->handle->writeAll($decoded);
             $this->remainder = substr($data, $usable);
         } else {
@@ -66,7 +66,7 @@ public function flush(): void
     {
         if ($this->remainder !== '') {
             // @codeCoverageIgnoreStart
-            $decoded = decode($this->remainder);
+            $decoded = namespace\decode($this->remainder);
             $this->remainder = '';
             $this->handle->writeAll($decoded);
             // @codeCoverageIgnoreEnd
diff --git a/src/Psl/Encoding/Hex/EncodingReadHandle.php b/src/Psl/Encoding/Hex/EncodingReadHandle.php
@@ -262,7 +262,7 @@ private function fillBuffer(CancellationTokenInterface $cancellation = new NullC
         }
 
         if ($chunk !== '') {
-            $this->buffer .= encode($chunk);
+            $this->buffer .= namespace\encode($chunk);
         }
     }
 }
diff --git a/src/Psl/Encoding/Hex/EncodingWriteHandle.php b/src/Psl/Encoding/Hex/EncodingWriteHandle.php
@@ -31,7 +31,7 @@ public function tryWrite(string $bytes): int
         $length = strlen($bytes);
 
         if ($length > 0) {
-            $encoded = encode($bytes);
+            $encoded = namespace\encode($bytes);
             $this->handle->writeAll($encoded);
         }
 
diff --git a/src/Psl/Encoding/Hex/decode.php b/src/Psl/Encoding/Hex/decode.php
@@ -6,6 +6,8 @@
 
 use Psl\Encoding\Exception;
 
+use function ctype_xdigit;
+use function hex2bin;
 use function strlen;
 
 /**
diff --git a/src/Psl/Encoding/Hex/encode.php b/src/Psl/Encoding/Hex/encode.php
@@ -4,6 +4,8 @@
 
 namespace Psl\Encoding\Hex;
 
+use function bin2hex;
+
 /**
  * Convert a binary string into a hexadecimal string.
  *
diff --git a/src/Psl/Encoding/QuotedPrintable/EncodingReadHandle.php b/src/Psl/Encoding/QuotedPrintable/EncodingReadHandle.php
@@ -246,7 +246,7 @@ private function fillBuffer(CancellationTokenInterface $cancellation = new NullC
                 // @codeCoverageIgnoreEnd
             }
 
-            $this->buffer .= encode_line($line);
+            $this->buffer .= namespace\encode_line($line);
             $this->firstLine = false;
 
             return;
@@ -260,7 +260,7 @@ private function fillBuffer(CancellationTokenInterface $cancellation = new NullC
                 $this->buffer .= "\r\n";
             }
 
-            $this->buffer .= encode_line($remaining);
+            $this->buffer .= namespace\encode_line($remaining);
         }
 
         $this->eof = true;
diff --git a/src/Psl/Encoding/QuotedPrintable/EncodingWriteHandle.php b/src/Psl/Encoding/QuotedPrintable/EncodingWriteHandle.php
@@ -55,7 +55,7 @@ public function flush(): void
                 $this->handle->writeAll("\r\n");
             }
 
-            $this->handle->writeAll(encode_line($line));
+            $this->handle->writeAll(namespace\encode_line($line));
             $this->buffer = '';
             $this->firstLine = false;
         }
@@ -72,7 +72,7 @@ private function drainCompleteLines(): void
                 $this->handle->writeAll("\r\n");
             }
 
-            $this->handle->writeAll(encode_line($line));
+            $this->handle->writeAll(namespace\encode_line($line));
             $this->firstLine = false;
         }
     }
diff --git a/src/Psl/Encoding/QuotedPrintable/encode.php b/src/Psl/Encoding/QuotedPrintable/encode.php
@@ -29,7 +29,7 @@ function encode(string $data, int $maxLineLength = 76, string $lineEnding = "\r\
     $result = [];
 
     foreach ($lines as $line) {
-        $result[] = encode_line($line, $maxLineLength, $lineEnding);
+        $result[] = namespace\encode_line($line, $maxLineLength, $lineEnding);
     }
 
     return implode($lineEnding, $result);
diff --git a/tests/benchmark/EncodingBench.php b/tests/benchmark/EncodingBench.php
@@ -9,6 +9,10 @@
 use Psl\Encoding\Base64;
 use Psl\Encoding\Hex;
 
+use function base64_encode;
+use function bin2hex;
+use function random_bytes;
+
 #[Groups(['encoding'])]
 final class EncodingBench
 {
diff --git a/tests/unit/Base64/DecodingReadHandleTest.php b/tests/unit/Base64/DecodingReadHandleTest.php
@@ -9,6 +9,9 @@
 use Psl\Encoding\Exception;
 use Psl\IO;
 
+use function base64_encode;
+use function str_repeat;
+
 final class DecodingReadHandleTest extends TestCase
 {
     public function testTryReadBufferNonEmptyNotEofDoesNotRefill(): void
diff --git a/tests/unit/Base64/EncodingReadHandleTest.php b/tests/unit/Base64/EncodingReadHandleTest.php
@@ -8,6 +8,7 @@
 use Psl\Encoding\Base64;
 use Psl\IO;
 
+use function str_repeat;
 use function strlen;
 
 final class EncodingReadHandleTest extends TestCase
diff --git a/tests/unit/Base64/StreamHandleTest.php b/tests/unit/Base64/StreamHandleTest.php
@@ -9,6 +9,11 @@
 use Psl\Encoding\Exception;
 use Psl\IO;
 
+use function base64_encode;
+use function str_repeat;
+use function strlen;
+use function substr;
+
 final class StreamHandleTest extends TestCase
 {
     public function testEncodingReadHandle(): void
diff --git a/tests/unit/Base64/WriteHandleTest.php b/tests/unit/Base64/WriteHandleTest.php
@@ -9,6 +9,9 @@
 use Psl\Encoding\Exception;
 use Psl\IO;
 
+use function str_repeat;
+use function strlen;
+
 final class WriteHandleTest extends TestCase
 {
     public function testDecodingWriteChunkedInputWithRemainder(): void
diff --git a/tests/unit/Base64MimeTest.php b/tests/unit/Base64MimeTest.php
@@ -10,6 +10,10 @@
 use Psl\Encoding\Exception;
 use Psl\SecureRandom;
 
+use function explode;
+use function str_repeat;
+use function strlen;
+
 final class Base64MimeTest extends TestCase
 {
     #[DataProvider('provideRandomBytes')]
diff --git a/tests/unit/EncodedWord/EncodeDecodeTest.php b/tests/unit/EncodedWord/EncodeDecodeTest.php
@@ -10,6 +10,10 @@
 use Psl\Encoding\Exception;
 use Psl\Str\Encoding;
 
+use function explode;
+use function str_repeat;
+use function strlen;
+
 final class EncodeDecodeTest extends TestCase
 {
     public function testEncodeEmptyString(): void
diff --git a/tests/unit/Hex/DecodingReadHandleTest.php b/tests/unit/Hex/DecodingReadHandleTest.php
@@ -9,6 +9,9 @@
 use Psl\Encoding\Hex;
 use Psl\IO;
 
+use function bin2hex;
+use function str_repeat;
+
 final class DecodingReadHandleTest extends TestCase
 {
     public function testTryReadBufferNonEmptyNotEofDoesNotRefill(): void
diff --git a/tests/unit/Hex/EncodingReadHandleTest.php b/tests/unit/Hex/EncodingReadHandleTest.php
@@ -8,6 +8,7 @@
 use Psl\Encoding\Hex;
 use Psl\IO;
 
+use function str_repeat;
 use function strlen;
 
 final class EncodingReadHandleTest extends TestCase
diff --git a/tests/unit/Hex/StreamHandleTest.php b/tests/unit/Hex/StreamHandleTest.php
@@ -9,6 +9,9 @@
 use Psl\Encoding\Hex;
 use Psl\IO;
 
+use function bin2hex;
+use function strlen;
+
 final class StreamHandleTest extends TestCase
 {
     public function testEncodingReadHandle(): void
diff --git a/tests/unit/QuotedPrintable/DecodingReadHandleTest.php b/tests/unit/QuotedPrintable/DecodingReadHandleTest.php
@@ -8,6 +8,8 @@
 use Psl\Encoding\QuotedPrintable;
 use Psl\IO;
 
+use function str_repeat;
+
 final class DecodingReadHandleTest extends TestCase
 {
     public function testTryReadBufferNonEmptyNotEofDoesNotRefill(): void
diff --git a/tests/unit/QuotedPrintable/EncodeDecodeTest.php b/tests/unit/QuotedPrintable/EncodeDecodeTest.php
@@ -8,6 +8,10 @@
 use PHPUnit\Framework\TestCase;
 use Psl\Encoding\QuotedPrintable;
 
+use function explode;
+use function str_repeat;
+use function strlen;
+
 final class EncodeDecodeTest extends TestCase
 {
     public function testEncodeEmptyString(): void
diff --git a/tests/unit/QuotedPrintable/EncodingReadHandleTest.php b/tests/unit/QuotedPrintable/EncodingReadHandleTest.php
@@ -8,6 +8,8 @@
 use Psl\Encoding\QuotedPrintable;
 use Psl\IO;
 
+use function explode;
+use function str_repeat;
 use function strlen;
 
 final class EncodingReadHandleTest extends TestCase
diff --git a/tests/unit/QuotedPrintable/StreamHandleTest.php b/tests/unit/QuotedPrintable/StreamHandleTest.php
@@ -8,6 +8,10 @@
 use Psl\Encoding\QuotedPrintable;
 use Psl\IO;
 
+use function explode;
+use function str_repeat;
+use function strlen;
+
 final class StreamHandleTest extends TestCase
 {
     public function testEncodingReadHandlePlainAscii(): void

Original file line number	Diff line number	Diff line change
`@@ -258,14 +258,14 @@ private function fillBuffer(CancellationTokenInterface $cancellation = new NullC`
`258`	`258`	`// @codeCoverageIgnoreEnd`
`259`	`259`	`}`
`260`	`260`
`261`		`- $chunk = $this->handle->read(CHUNK_SIZE, $cancellation);`
	`261`	`+ $chunk = $this->handle->read(namespace\CHUNK_SIZE, $cancellation);`
`262`	`262`	`if ($chunk === '' && $this->handle->reachedEndOfDataSource()) {`
`263`	`263`	`$this->eof = true;`
`264`	`264`	`return;`
`265`	`265`	`}`
`266`	`266`
`267`	`267`	`if ($chunk !== '') {`
`268`		`- $this->buffer .= encode($chunk, $this->variant, $this->padding) . LINE_ENDING;`
	`268`	`+ $this->buffer .= namespace\encode($chunk, $this->variant, $this->padding) . namespace\LINE_ENDING;`
`269`	`269`	`}`
`270`	`270`	`}`
`271`	`271`	`}`
Original file line number	Diff line number	Diff line change
`@@ -31,7 +31,7 @@ function decode_payload(string $encoding, string $text): string`
`31`	`31`	`}`
`32`	`32`
`33`	`33`	`if ($encoding === EncodedWord\Q_ENCODING) {`
`34`		`- return q_decode($text);`
	`34`	`+ return namespace\q_decode($text);`
`35`	`35`	`}`
`36`	`36`
`37`	`37`	`// @codeCoverageIgnoreStart`
Original file line number	Diff line number	Diff line change
`@@ -262,7 +262,7 @@ private function fillBuffer(CancellationTokenInterface $cancellation = new NullC`
`262`	`262`	`}`
`263`	`263`
`264`	`264`	`if ($chunk !== '') {`
`265`		`- $this->buffer .= encode($chunk);`
	`265`	`+ $this->buffer .= namespace\encode($chunk);`
`266`	`266`	`}`
`267`	`267`	`}`
`268`	`268`	`}`
Original file line number	Diff line number	Diff line change
`@@ -31,7 +31,7 @@ public function tryWrite(string $bytes): int`
`31`	`31`	`$length = strlen($bytes);`
`32`	`32`
`33`	`33`	`if ($length > 0) {`
`34`		`- $encoded = encode($bytes);`
	`34`	`+ $encoded = namespace\encode($bytes);`
`35`	`35`	`$this->handle->writeAll($encoded);`
`36`	`36`	`}`
`37`	`37`