fix test

Signed-off-by: Joey Smith <jsmith@webinertia.net>

Author: tyrsson

phpstan-baseline.neon

@@ -1,13 +1,2 @@
 parameters:
 	ignoreErrors:
-		-
-			message: '#^Callable PhpDb\\Sqlite\\Container\\PdoStatementFactory invoked with 1 parameter, 2\-3 required\.$#'
-			identifier: arguments.count
-			count: 1
-			path: test/integration/Container/PdoStatementFactoryTest.php
-
-		-
-			message: '#^Callable PhpDb\\Sqlite\\Container\\PdoStatementFactory invoked with 1 parameter, 2\-3 required\.$#'
-			identifier: arguments.count
-			count: 3
-			path: test/unit/Container/PdoStatementFactoryTest.php

src/Container/PdoConnectionFactory.php

@@ -9,6 +9,8 @@
 use PhpDb\Sqlite\Pdo\Connection;
 use Psr\Container\ContainerInterface;
 
+use function is_array;
+
 final class PdoConnectionFactory
 {
     public function __invoke(

test/integration/Container/PdoConnectionFactoryTest.php

@@ -24,7 +24,7 @@ final class PdoConnectionFactoryTest extends TestCase
     public function testInvokeReturnsPdoConnection(): void
     {
         $factory  = new PdoConnectionFactory();
-        $instance = $factory($this->container);
+        $instance = $factory($this->container, Connection::class, ['connection' => ['dsn' => 'sqlite::memory:']]);
         self::assertInstanceOf(ConnectionInterface::class, $instance);
         self::assertInstanceOf(PdoConnectionInterface::class, $instance);
         self::assertInstanceOf(Connection::class, $instance);

test/integration/Container/PdoStatementFactoryTest.php

@@ -23,7 +23,7 @@ final class PdoStatementFactoryTest extends TestCase
     public function testInvokeReturnsPdoStatement(): void
     {
         $factory   = new PdoStatementFactory();
-        $statement = $factory($this->container);
+        $statement = $factory($this->container, Statement::class, []);
         self::assertInstanceOf(StatementInterface::class, $statement);
         self::assertInstanceOf(Statement::class, $statement);
     }

test/integration/Container/SqliteMetadataFactoryTest.php

@@ -20,7 +20,7 @@ final class SqliteMetadataFactoryTest extends TestCase
     public function testFactoryReturnsMysqlMetadata(): void
     {
         $factory  = new MetadataInterfaceFactory();
-        $metadata = $factory($this->container);
+        $metadata = $factory($this->container, Metadata\Source::class);
         self::assertInstanceOf(MetadataInterface::class, $metadata);
         self::assertInstanceOf(Metadata\Source::class, $metadata);
     }

test/unit/Container/MetadataInterfaceFactoryTest.php

@@ -33,7 +33,7 @@ public function testInvokeReturnsMetadata(): void
             ->willReturn($adapterMock);
 
         $factory  = new MetadataInterfaceFactory();
-        $metadata = $factory($containerMock);
+        $metadata = $factory($containerMock, Metadata\Source::class);
 
         self::assertInstanceOf(Metadata\Source::class, $metadata);
     }

test/unit/Container/PdoConnectionFactoryTest.php

@@ -4,6 +4,7 @@
 
 namespace PhpDbTest\Sqlite\Container;
 
+use PhpDb\Adapter\Exception\InvalidConnectionParametersException;
 use PhpDb\Sqlite\Container\PdoConnectionFactory;
 use PhpDb\Sqlite\Pdo\Connection;
 use PHPUnit\Framework\Attributes\CoversClass;
@@ -16,47 +17,30 @@ final class PdoConnectionFactoryTest extends TestCase
     public function testInvokeReturnsConnection(): void
     {
         $containerMock = $this->createMock(ContainerInterface::class);
-        $containerMock->method('get')
-            ->with('config')
-            ->willReturn([
-                'db' => [
-                    'connection' => [
-                        'dsn' => 'sqlite::memory:',
-                    ],
-                ],
-            ]);
 
         $factory    = new PdoConnectionFactory();
-        $connection = $factory($containerMock);
+        $connection = $factory($containerMock, Connection::class, ['connection' => ['dsn' => 'sqlite::memory:']]);
 
         self::assertInstanceOf(Connection::class, $connection);
     }
 
-    public function testInvokeWithoutConnectionConfig(): void
+    public function testInvokeWithoutConnectionConfigThrows(): void
     {
         $containerMock = $this->createMock(ContainerInterface::class);
-        $containerMock->method('get')
-            ->with('config')
-            ->willReturn([
-                'db' => [],
-            ]);
 
-        $factory    = new PdoConnectionFactory();
-        $connection = $factory($containerMock);
+        $this->expectException(InvalidConnectionParametersException::class);
 
-        self::assertInstanceOf(Connection::class, $connection);
+        $factory = new PdoConnectionFactory();
+        $factory($containerMock, Connection::class, []);
     }
 
-    public function testInvokeWithoutDbConfig(): void
+    public function testInvokeWithNullOptionsThrows(): void
     {
         $containerMock = $this->createMock(ContainerInterface::class);
-        $containerMock->method('get')
-            ->with('config')
-            ->willReturn([]);
 
-        $factory    = new PdoConnectionFactory();
-        $connection = $factory($containerMock);
+        $this->expectException(InvalidConnectionParametersException::class);
 
-        self::assertInstanceOf(Connection::class, $connection);
+        $factory = new PdoConnectionFactory();
+        $factory($containerMock, Connection::class, null);
     }
 }

test/unit/Container/PdoStatementFactoryTest.php

@@ -4,7 +4,6 @@
 
 namespace PhpDbTest\Sqlite\Container;
 
-use PhpDb\Adapter\AdapterInterface;
 use PhpDb\Adapter\Driver\Pdo\Statement;
 use PhpDb\Sqlite\Container\PdoStatementFactory;
 use PHPUnit\Framework\Attributes\CoversClass;
@@ -14,47 +13,22 @@
 #[CoversClass(PdoStatementFactory::class)]
 final class PdoStatementFactoryTest extends TestCase
 {
-    public function testInvokeReturnsStatement(): void
+    public function testInvokeReturnsStatementWithOptions(): void
     {
         $containerMock = $this->createMock(ContainerInterface::class);
-        $containerMock->method('get')
-            ->with('config')
-            ->willReturn([
-                AdapterInterface::class => [
-                    'options' => [],
-                ],
-            ]);
 
         $factory   = new PdoStatementFactory();
-        $statement = $factory($containerMock);
+        $statement = $factory($containerMock, Statement::class, ['key' => 'value']);
 
         self::assertInstanceOf(Statement::class, $statement);
     }
 
-    public function testInvokeWithoutOptionsConfig(): void
+    public function testInvokeReturnsStatementWithEmptyOptions(): void
     {
         $containerMock = $this->createMock(ContainerInterface::class);
-        $containerMock->method('get')
-            ->with('config')
-            ->willReturn([
-                AdapterInterface::class => [],
-            ]);
 
         $factory   = new PdoStatementFactory();
-        $statement = $factory($containerMock);
-
-        self::assertInstanceOf(Statement::class, $statement);
-    }
-
-    public function testInvokeWithoutDbConfig(): void
-    {
-        $containerMock = $this->createMock(ContainerInterface::class);
-        $containerMock->method('get')
-            ->with('config')
-            ->willReturn([]);
-
-        $factory   = new PdoStatementFactory();
-        $statement = $factory($containerMock);
+        $statement = $factory($containerMock, Statement::class, []);
 
         self::assertInstanceOf(Statement::class, $statement);
     }