Skip to content

Build - fix(backup): close two teardown gaps flagged in code review Don't SetError("shutdown in progress") from Execute() during teardown. That routes through node-addon-api's parent OnWorkComplete, which constructs OnError(Error::New(env, _error)) inside WrapCallback - still a teardown-time napi touch whose failure mode is ThrowAsJavaScriptException. Return with empty _error instead so dispatch goes through OnOK, where the existing shutting_down_ guard short-circuits before deferred_. Stop reading pro... #298

Build - fix(backup): close two teardown gaps flagged in code review Don't SetError("shutdown in progress") from Execute() during teardown. That routes through node-addon-api's parent OnWorkComplete, which constructs OnError(Error::New(env, _error)) inside WrapCallback - still a teardown-time napi touch whose failure mode is ThrowAsJavaScriptException. Return with empty _error instead so dispatch goes through OnOK, where the existing shutting_down_ guard short-circuits before deferred_. Stop reading pro...

Build - fix(backup): close two teardown gaps flagged in code review Don't SetError("shutdown in progress") from Execute() during teardown. That routes through node-addon-api's parent OnWorkComplete, which constructs OnError(Error::New(env, _error)) inside WrapCallback - still a teardown-time napi touch whose failure mode is ThrowAsJavaScriptException. Return with empty _error instead so dispatch goes through OnOK, where the existing shutting_down_ guard short-circuits before deferred_. Stop reading pro... #298

Job Run time
1m 4s
4m 16s
47s
2m 2s
2m 15s
2m 15s
1m 48s
2m 37s
2m 7s
49s
52s
3m 37s
48s
54s
3m 14s
3m 12s
3m 4s
49s
49s
3m 3s
54s
2m 49s
5m 3s
2m 44s
51s
5m 41s
1m 7s
5m 32s
1m 28s
1m 10s
5m 33s
6m 0s
1m 12s
28s
23s
1m 1s
1m 24s
6m 48s
1m 41s
2m 49s
9m 44s
10m 11s
1m 29s
2m 7s
1m 40s
8m 47s
1m 27s
9m 0s
12m 14s
2m 29s
8m 41s
7m 53s
-1s
2h 50m 41s