Git Worktree List reports error _not in a worktree_, possibly issue with UNC path?

[msftrncs]

Version: 1.3.2
Worktree and Git path: \\USNEFS100.rosenbauer.local\media\GIT Repositories\y2020_controller (./.git)
Additional worktree: \\USNEFS100.rosenbauer.local\media\GIT Repositories\y2020_controller_3

I receive the following error message in VS Code's right bottom notification area when I attempt Git Worktree: List:

---------------- Error Message ----------------

You are not in a worktree or bare repo

I initially started in C:\Repositories\y2020_controller_4 and I switched to worktree \\USNEFS100.rosenbauer.local\media\GIT Repositories\y2020_controller using the Git Worktree: List command. I attempted to list worktrees again at this point and received the error. I manually switched folders in VS Code to another worktree in the same repository (y2020_controller_3) and the same message occurs on the Get Worktree: List command there.

Yes, I have worktrees on a network drive and on a local drive, and since this evolved from a regular repository, one of the worktrees is the original clone with the .git folder. This strategy first evolved because it is a large repository and I can switch workstations without notice so keeping the repository on a network drive facilitated that, but later needed to move a worktree (1 at first) to a local drive to speed up the build process.

I am wondering about the space in the repository path since I have no problem when running the command from y2020_controller_4. It might have to do with needing to escape/quote the spaces in the path when executing Git commands or VS Code?

However I am also having some difficulties with Git Worktree since I do not have a bare repository clone. Keep in mind I am evaluating Git Worktree, as I already know how to work with GIT work trees manually from the command line.

[philstainer]

Hi, firstly thanks for the report! Can I ask if you moved the worktree manually? If so you need to make sure to update the path reference (should be a file inside your .bare repo (see screenshot)

Just tested having a worktree outside the bare repo and seems to be working for me (I'm not using a network drive location though).

I have also just pushed another update to hopefully fix the rest of the issues with spaces in the paths.

[philstainer]

Also, just wanted to add, this extension ideally wants you to go all in on git worktrees, clone the repo using the clone command (this will setup the bare repo etc), then use the add command to add worktrees.

Having a normal repo and adding worktrees can be painful and isn't the cleanest solution hence the workflow this extension tries to push you towards.

Would need to think about how I could support both, not sure I can.

[msftrncs]

Yes, I initially created the worktree on the network, and then moved it manually to a local drive, and then fixed all of Git's configuration or Git wouldn't work. I have been using this repository and many work trees of it for a couple years now.

I've been doing more testing with blank repositories and it appears it might be something related to network paths. I created two nearly identical repositories as just blank points of reference.

• C:\Repositories\Test Repository.git (bare)
• C:\Repositories\Test Repository\Test_1 (worktree 1)
• C:\Repositories\Test Repository\Test_2 (worktree 2)

The above all works fine and Git Worktree can switch between both worktrees and the bare base folder.

• \server\share\Git Repositories\Test Repository.git (bare)
• \server\share\Git Repositories\Test Repository\Test_1 (worktree 1)
• \server\share\Git Repositories\Test Repository\Test_2 (worktree 2)

These UNC paths cause Git Worktree: List command to fail 'You are not in a worktree or bare repo'.

In both cases I started VS Code from the bare repository folder, and I created all the worktrees using git worktree add.

I happen to have a mapped drive to the network path above, where R:\ refers to \\server\share\Git Repositories. If I open the repository in VS Code from the mapped drive reference, then Git Worktree: List works, except that it is listing the UNC based paths to the worktrees, so that if I switch to one it will then fail after that.

A possible reason for this is if spawning Git commands involves using Command (CMD) shell on Windows. CMD doesn't support UNC paths for CWD and thus switches to %windir% before executing any requested commands, which would cause Git to detect no repository.

[philstainer]

This is a tricky one, the extension is going to use the path returned by git worktree list --porcelain so if thats returning:

worktree //USNEFS100.rosenbauer.local/media/GIT Repositories/y2020_controller
HEAD a5ebc13237f7ebf5630a1250f5f84e7279de7052
branch refs/heads/RNEAerial_Prototype/PrototypeDev_RaST

Then thats the path it will use 😔

This is how we are currently running commands:

git-worktree/src/helpers/general.ts

Lines 26 to 39 in 5e03e32

	export const executeCommand = async (
	command: string,
	options?: ExecOptions
	) => {
	let execOptions = { ...options, cwd: options?.cwd ?? getCurrentPath() };
	try {
	const { stdout } = await exec(command, execOptions);
	return { stdout };
	} catch (e: any) {
	const errorMessage = `command: '${command}'. error: '${e.message}'`;
	throw Error(errorMessage);
	}
	};

Any suggestions on a fix?

[msftrncs]

I am pretty sure that method on Windows causes a spawn of CMD to handle the 'command'.

I tried searching if VS Code provided any API's to Git and was disappointed that they do not seem to provide any that would be useful here, though it might just not be documented. However that search turned up how GetLens calls Git.

https://github.com/gitkraken/vscode-gitlens/blob/6cfd9fdedd7c6ec3bfa732af7c418bbbecdfba54/src/git/shell.ts#L144-L182

This is using child_process.execFile(), and they previously find the exact path to the Git executable so they call Git specifically at that path, and provide the arguments separately.

The VS Code Git Extension appears to use child_process.spawn(), and they similarly find the Git executable previously too.

https://github.com/microsoft/vscode/blob/080fe3a4988e15a6205aea2cf79cd87c0c499ae4/extensions/git/src/git.ts#L664-L690