Skip to content

Static tests "app_package_name" and "valid_app_name_and_guid" fail on local / development apps #210

@skatt-konraduh

Description

@skatt-konraduh

Hi,

When developing new or internal Splunk SOAR apps using the SDK, the static tests in the pre-commit hooks fail on:

  • app_package_name
  • valid_app_name_and_guid

I assume this is because neither local_hooks/data/appid_to_package_name.json, local_hooks/data/appid_to_name.json contain the app ID the SOAR App wizard generated for us. Might be useful to skip this test in the same manner as the others?

-------------------------------------------------------
                       JSONTests                       
-------------------------------------------------------
PASSED - action_param_matching_contains: TEST SKIPPED - SDK app detected
PASSED - action_param_prefixes         : TEST SKIPPED - SDK app detected
FAILED - app_package_name              : GUID and app package name not listed in [...]/site-packages/local_hooks/data/appid_to_package_name.json
PASSED - extra_fields_app_json         : TEST SKIPPED - SDK app detected
PASSED - main_module                   : TEST SKIPPED - SDK app detected
PASSED - min_platform_version          : OK
PASSED - minimal_data_paths            : TEST SKIPPED - SDK app detected
PASSED - pip313_dependencies           : TEST SKIPPED - SDK app detected
PASSED - sequential_order              : TEST SKIPPED - SDK app detected
PASSED - test_connectivity             : OK
FAILED - valid_app_name_and_guid       : GUID and app not listed in [...]/site-packages/local_hooks/data/appid_to_name.json
PASSED - fields_should_be_passwords    : OK
PASSED - validate_json_schema          : TEST SKIPPED - SDK app detected

Thank you for the consideration 💯

BR,
Konrad

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions