Added more tests for SparseVector

Author: ankane

test/helper.hpp

@@ -0,0 +1,20 @@
+#pragma once
+
+#include <cassert>
+#include <functional>
+#include <optional>
+#include <string_view>
+
+template<typename T>
+void assert_exception(std::function<void(void)> code, std::optional<std::string_view> message = std::nullopt) {
+    bool exception = false;
+    try {
+        code();
+    } catch (const T& e) {
+        exception = true;
+        if (message) {
+            assert(std::string_view(e.what()) == *message);
+        }
+    }
+    assert(exception);
+}

test/pqxx_test.cpp

@@ -1,14 +1,14 @@
 #include <cassert>
-#include <functional>
 #include <optional>
 #include <string>
 #include <string_view>
 #include <vector>
 
 #include <pqxx/pqxx>
-
 #include <pgvector/pqxx.hpp>
 
+#include "helper.hpp"
+
 void setup(pqxx::connection &conn) {
     pqxx::nontransaction tx(conn);
     tx.exec("CREATE EXTENSION IF NOT EXISTS vector");
@@ -21,20 +21,6 @@ void before_each(pqxx::connection &conn) {
     tx.exec("TRUNCATE items");
 }
 
-template<typename T>
-void assert_exception(std::function<void(void)> code, std::optional<std::string_view> message = std::nullopt) {
-    bool exception = false;
-    try {
-        code();
-    } catch (const T& e) {
-        exception = true;
-        if (message) {
-            assert(std::string_view(e.what()) == *message);
-        }
-    }
-    assert(exception);
-}
-
 std::optional<std::string_view> float_error([[maybe_unused]] std::string_view message) {
 #ifdef __linux__
     return message;

test/sparsevec_test.cpp

@@ -4,6 +4,8 @@
 
 #include <pgvector/sparsevec.hpp>
 
+#include "helper.hpp"
+
 using pgvector::SparseVector;
 
 static void test_constructor_vector() {
@@ -24,6 +26,14 @@ static void test_constructor_map() {
     assert(vec.dimensions() == 6);
     assert(vec.indices() == (std::vector<int>{0, 2, 4}));
     assert(vec.values() == (std::vector<float>{1, 2, 3}));
+
+    assert_exception<std::invalid_argument>([&]{
+        auto unused = SparseVector(map, 0);
+    }, "sparsevec must have at least 1 dimension");
+
+    assert_exception<std::invalid_argument>([&]{
+        auto unused = SparseVector(map, 4);
+    }, "sparsevec index out of bounds");
 }
 
 void test_sparsevec() {