Removed unnecessary copying

Author: ankane

include/pgvector/pqxx.hpp

@@ -201,7 +201,7 @@ template <> struct string_traits<pgvector::SparseVector> {
             cb(inner.substr(start));
         }
 
-        return pgvector::SparseVector(dimensions, indices, values);
+        return pgvector::SparseVector(dimensions, std::move(indices), std::move(values));
     }
 
     static std::string_view to_buf(std::span<char> buf, const pgvector::SparseVector& value, ctx c = {}) {

include/pgvector/sparsevec.hpp

@@ -28,6 +28,16 @@ class SparseVector {
         values_ = values;
     }
 
+    /// @private
+    SparseVector(int dimensions, std::vector<int>&& indices, std::vector<float>&& values) {
+        if (values.size() != indices.size()) {
+            throw std::invalid_argument("indices and values must be the same length");
+        }
+        dimensions_ = dimensions;
+        indices_ = std::move(indices);
+        values_ = std::move(values);
+    }
+
     /// Creates a sparse vector from a dense vector.
     explicit SparseVector(const std::vector<float>& value) {
         dimensions_ = value.size();