tests: adjust Service model tests for new structure

Author: jaredhendrickson13

pfSense-pkg-RESTAPI/files/usr/local/pkg/RESTAPI/Tests/APIModelsServiceTestCase.inc

@@ -22,37 +22,12 @@ class APIModelsServiceTestCase extends TestCase {
         }
     }
 
-    /**
-     * Checks that the `get_service_name_choices()` method correctly identifies all available service names.
-     */
-    public function test_get_service_name_choices(): void {
-        # Ensure expected services are found in the method's response
-        $expected_services = ['unbound', 'ntpd', 'syslogd', 'dhcpd', 'dpinger', 'sshd'];
-
-        # Loop through each expected service and ensure it is found
-        foreach ($expected_services as $service) {
-            $this->assert_is_true(in_array($service, (new Service())->get_service_name_choices()));
-        }
-    }
-
-    /**
-     * Checks that the `get_id_by_name()` correctly obtains the ID of the Service object with a specific `name`
-     */
-    public function test_get_id_by_name(): void {
-        # Create a Service object to test with
-        $test_service = new Service();
-
-        # Obtain the ID of the `sshd` service and ensure the correct ID was given
-        $sshd_id = $test_service->get_id_by_name('sshd');
-        $this->assert_equals($sshd_id, $test_service->query(['name' => 'sshd'])->first()->id);
-    }
-
     /**
      * Checks that a Service can be stopped, started and restarted.
      */
     public function test_can_perform_service_actions(): void {
-        # Define a Service to test with
-        $test_service = new Service(data: ['name' => 'ntpd']);
+        # Obtain a Service to test with
+        $test_service = Service::query(name: "ntpd")->first();
 
         # Ensure the service can be stopped
         $test_service->action->value = 'stop';