test: adjust UserGroup model creation during tests

Author: jaredhendrickson13

pfSense-pkg-RESTAPI/files/usr/local/pkg/RESTAPI/Tests/APIModelsUserGroupTestCase.inc

@@ -129,15 +129,12 @@ class APIModelsUserGroupTestCase extends TestCase {
      * the 'system' scope.
      */
     public function test_cannot_create_or_update_user_groups_with_system_scope(): void {
-        # Create a UserGroup to test with
-        $user_group = new UserGroup();
-
         # Ensure attempts to create UserGroups with the system scope are rejected
         $this->assert_throws_response(
             response_id: 'USER_GROUP_SCOPE_CANNOT_BE_SET_TO_SYSTEM',
             code: 422,
-            callable: function () use ($user_group) {
-                $user_group->scope->value = 'system';
+            callable: function () {
+                $user_group = new UserGroup(name: 'testgroup', scope: 'system');
                 $user_group->create();
             },
         );
@@ -146,7 +143,7 @@ class APIModelsUserGroupTestCase extends TestCase {
         $this->assert_throws_response(
             response_id: 'USER_GROUP_SCOPE_CANNOT_BE_SET_TO_SYSTEM',
             code: 422,
-            callable: function () use ($user_group) {
+            callable: function () {
                 # Create a local UserGroup to test with
                 $user_group = new UserGroup(data: ['name' => 'testgroup', 'scope' => 'local']);
                 $user_group->create();
@@ -157,9 +154,6 @@ class APIModelsUserGroupTestCase extends TestCase {
             },
         );
 
-        # Delete the test UserGroup
-        $user_group->delete();
-
         # Ensure we CAN update an existing UserGroup with the system scope to still have the system scope
         $this->assert_does_not_throw(
             callable: function () {