Add content fallback for Bridgy webmentions without text #549
+75
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Extract video/audio URLs as link content when no text content exists - Use registered comment type excerpt templates as fallback for reactions (likes, reposts, etc.) - Add video-reply test fixture Fixes #438
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds fallback mechanisms for webmentions that lack text content, specifically targeting Bridgy webmentions. It implements two fallback strategies: extracting video/audio URLs as clickable links when no content property exists, and using registered comment type excerpt templates (e.g., "liked this", "reposted this") for reaction-type webmentions.
Key changes:
- Video/audio URL extraction as fallback content in the MF2 handler
- Comment type excerpt template fallback in the Item entity's
get_content()method
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| tests/data/mf2/video-reply.html | Test fixture HTML for video-only webmention with microformats markup |
| tests/data/mf2/video-reply.json | Expected test output showing video URL as content |
| readme.md | Changelog entries documenting the new fallback features |
| includes/Handler/class-mf2.php | Video/audio URL extraction logic with proper URL validation and escaping |
| includes/Entity/class-item.php | Excerpt template fallback method that generates content from comment type templates |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #438
Test Plan