Hello,
During a recent PR review, we noticed that the DataViewTreeViewFilter contains an extra button ("Close label group <filter_name>") in the chip toolbar that isn't present in other data-view filters:
I’d like to propose adding a prop (e.g., showDeleteLabelGroup) to control this behavior
It appears that in the ToolbarFilter component, the button's visibility is tied to the presence of the deleteLabelGroup function. If we provide a way to ensure this remains undefined or is explicitly disabled via a prop, the button should remain hidden as expected
Many thanks for considering the change!
Jira Issue: PF-4094
Hello,
During a recent PR review, we noticed that the
DataViewTreeViewFiltercontains an extra button ("Close label group <filter_name>") in the chip toolbar that isn't present in other data-view filters:I’d like to propose adding a prop (e.g.,
showDeleteLabelGroup) to control this behaviorIt appears that in the
ToolbarFiltercomponent, the button's visibility is tied to the presence of thedeleteLabelGroupfunction. If we provide a way to ensure this remains undefined or is explicitly disabled via a prop, the button should remain hidden as expectedMany thanks for considering the change!
Jira Issue: PF-4094