Skip to content

Commit df966da

Browse files
committed
fix(Select): add button wrapping to typeahead carat, update tests
1 parent e05fc30 commit df966da

2 files changed

Lines changed: 176 additions & 145 deletions

File tree

packages/patternfly-4/react-core/src/components/Select/SelectToggle.js

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
import React, { Component } from 'react';
22
import styles from '@patternfly/patternfly/components/Select/select.css';
3+
import buttonStyles from '@patternfly/patternfly/components/Button/button.css';
34
import { css } from '@patternfly/react-styles';
45
import PropTypes from 'prop-types';
56
import { CaretDownIcon } from '@patternfly/react-icons';
@@ -157,7 +158,12 @@ class SelectToggle extends Component {
157158
onKeyDown={this.onKeyDown}
158159
>
159160
{children}
160-
<CaretDownIcon className={css(styles.selectToggleArrow)} />
161+
{isTypeahead && (
162+
<button className={css(buttonStyles.button, styles.selectToggleButton)}>
163+
<CaretDownIcon className={css(styles.selectToggleArrow)} />
164+
</button>
165+
)}
166+
{!isTypeahead && <CaretDownIcon className={css(styles.selectToggleArrow)} />}
161167
</ToggleComponent>
162168
);
163169
}

0 commit comments

Comments
 (0)