Skip to content

Commit aba1ac7

Browse files
authored
chore(ExternalLinkSquareAltIcon): Replace all usages of ExternalLinkSquareAltIcon with RhUiExternalLinkFillIcon (#12366)
* chore(ExternalLinkSquareAltIcon): Replace all usages of ExternalLinkSquareAltIcon with RhUiExternalLinkFillIcon * update pfToRhIcons
1 parent c8d8d7c commit aba1ac7

7 files changed

Lines changed: 11 additions & 11 deletions

File tree

packages/react-core/src/components/Button/examples/Button.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ ouia: true
99
import { Fragment, useState } from 'react';
1010
import RhMicronsCloseIcon from '@patternfly/react-icons/dist/esm/icons/rh-microns-close-icon';
1111
import PlusCircleIcon from '@patternfly/react-icons/dist/esm/icons/plus-circle-icon';
12-
import ExternalLinkSquareAltIcon from '@patternfly/react-icons/dist/esm/icons/external-link-square-alt-icon';
12+
import RhUiExternalLinkFillIcon from '@patternfly/react-icons/dist/esm/icons/rh-ui-external-link-fill-icon';
1313
import CopyIcon from '@patternfly/react-icons/dist/esm/icons/copy-icon';
1414
import ArrowRightIcon from '@patternfly/react-icons/dist/esm/icons/arrow-right-icon';
1515
import UploadIcon from '@patternfly/react-icons/dist/esm/icons/upload-icon';

packages/react-core/src/components/Button/examples/ButtonVariations.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
import { Button, Flex } from '@patternfly/react-core';
22
import RhMicronsCloseIcon from '@patternfly/react-icons/dist/esm/icons/rh-microns-close-icon';
33
import PlusCircleIcon from '@patternfly/react-icons/dist/esm/icons/plus-circle-icon';
4-
import ExternalLinkSquareAltIcon from '@patternfly/react-icons/dist/esm/icons/external-link-square-alt-icon';
4+
import RhUiExternalLinkFillIcon from '@patternfly/react-icons/dist/esm/icons/rh-ui-external-link-fill-icon';
55
import CopyIcon from '@patternfly/react-icons/dist/esm/icons/copy-icon';
66
import RhUiNotificationFillIcon from '@patternfly/react-icons/dist/esm/icons/rh-ui-notification-fill-icon';
77

@@ -32,7 +32,7 @@ export const ButtonVariations: React.FunctionComponent = () => (
3232
<Button variant="link" icon={<PlusCircleIcon />}>
3333
Link
3434
</Button>
35-
<Button variant="link" icon={<ExternalLinkSquareAltIcon />} iconPosition="end">
35+
<Button variant="link" icon={<RhUiExternalLinkFillIcon />} iconPosition="end">
3636
Link
3737
</Button>
3838
<Button variant="link" isInline>

packages/react-core/src/components/SearchInput/__tests__/SearchInput.test.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ import { SearchInput } from '../SearchInput';
66
import { FormGroup } from '../../Form';
77
import { Button } from '../../Button';
88
import { AnimationsProvider } from '../../../helpers/AnimationsProvider';
9-
import ExternalLinkSquareAltIcon from '@patternfly/react-icons/dist/esm/icons/external-link-square-alt-icon';
9+
import RhUiExternalLinkFillIcon from '@patternfly/react-icons/dist/esm/icons/rh-ui-external-link-fill-icon';
1010
import badgeStyles from '@patternfly/react-styles/css/components/Badge/badge';
1111
import textInputGroupStyles from '@patternfly/react-styles/css/components/TextInputGroup/text-input-group';
1212
import inputGroupStyles from '@patternfly/react-styles/css/components/InputGroup/input-group';
@@ -128,7 +128,7 @@ describe('SearchInput', () => {
128128
advancedSearchDelimiter=":"
129129
formAdditionalItems={
130130
<FormGroup fieldId="test-form-group">
131-
<Button variant="link" isInline icon={<ExternalLinkSquareAltIcon />} iconPosition="right">
131+
<Button variant="link" isInline icon={<RhUiExternalLinkFillIcon />} iconPosition="right">
132132
Link
133133
</Button>
134134
</FormGroup>

packages/react-core/src/components/SearchInput/__tests__/__snapshots__/SearchInput.test.tsx.snap

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -496,11 +496,11 @@ exports[`SearchInput advanced search with custom attributes 1`] = `
496496
fill="currentColor"
497497
height="1em"
498498
role="img"
499-
viewBox="0 0 448 512"
499+
viewBox="0 0 32 32"
500500
width="1em"
501501
>
502502
<path
503-
d="M448 80v352c0 26.51-21.49 48-48 48H48c-26.51 0-48-21.49-48-48V80c0-26.51 21.49-48 48-48h352c26.51 0 48 21.49 48 48zm-88 16H248.029c-21.313 0-32.08 25.861-16.971 40.971l31.984 31.987L67.515 364.485c-4.686 4.686-4.686 12.284 0 16.971l31.029 31.029c4.687 4.686 12.285 4.686 16.971 0l195.526-195.526 31.988 31.991C358.058 263.977 384 253.425 384 231.979V120c0-13.255-10.745-24-24-24z"
503+
d="M28.5 2h-25C2.673 2 2 2.673 2 3.5v25c0 .827.673 1.5 1.5 1.5h25c.827 0 1.5-.673 1.5-1.5v-25c0-.827-.673-1.5-1.5-1.5Zm-3.375 17a1.125 1.125 0 0 1-2.25 0v-8.284L11.796 21.795a1.122 1.122 0 0 1-1.592 0 1.127 1.127 0 0 1 0-1.591l11.08-11.08H13a1.125 1.125 0 0 1 0-2.25h10.5c.896 0 1.625.729 1.625 1.625v10.5Z"
504504
/>
505505
</svg>
506506
</span>

packages/react-core/src/components/SearchInput/examples/SearchInput.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ propComponents: ['SearchInput', 'SearchInputSearchAttribute', 'SearchInputExpand
66
---
77

88
import { useRef, useState } from 'react';
9-
import { ExternalLinkSquareAltIcon } from '@patternfly/react-icons';
9+
import RhUiExternalLinkFillIcon from '@patternfly/react-icons/dist/esm/icons/rh-ui-external-link-fill-icon';
1010

1111
## Examples
1212

packages/react-core/src/components/SearchInput/examples/SearchInputAdvanced.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
import { useState } from 'react';
22
import { Button, Checkbox, FormGroup, SearchInput } from '@patternfly/react-core';
3-
import ExternalLinkSquareAltIcon from '@patternfly/react-icons/dist/esm/icons/external-link-square-alt-icon';
3+
import RhUiExternalLinkFillIcon from '@patternfly/react-icons/dist/esm/icons/rh-ui-external-link-fill-icon';
44

55
export const SearchInputAdvanced: React.FunctionComponent = () => {
66
const [value, setValue] = useState('username:player firstname:john');
@@ -45,7 +45,7 @@ export const SearchInputAdvanced: React.FunctionComponent = () => {
4545
formAdditionalItems={
4646
useCustomFooter ? (
4747
<FormGroup>
48-
<Button variant="link" isInline icon={<ExternalLinkSquareAltIcon />} iconPosition="end">
48+
<Button variant="link" isInline icon={<RhUiExternalLinkFillIcon />} iconPosition="end">
4949
Link
5050
</Button>
5151
</FormGroup>

packages/react-icons/scripts/icons/pfToRhIcons.mjs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -63,7 +63,7 @@ export const pfToRhIcons = {
6363
ExpandArrowsAltIcon: { name: 'rh-ui-expand-arrows', icon: getIconData('rh-ui-expand-arrows') },
6464
ExpandIcon: { name: 'rh-ui-expand', icon: getIconData('rh-ui-expand') },
6565
ExportIcon: { name: 'rh-ui-export', icon: getIconData('rh-ui-export') },
66-
ExternalLinkAltIcon: { name: 'rh-ui-external-link', icon: getIconData('rh-ui-external-link') },
66+
ExternalLinkAltIcon: { name: 'rh-ui-external-link-fill', icon: getIconData('rh-ui-external-link-fill') },
6767
EyeIcon: { name: 'rh-ui-view', icon: getIconData('rh-ui-view') },
6868
EyeSlashIcon: { name: 'rh-ui-view-off', icon: getIconData('rh-ui-view-off') },
6969
FileIcon: { name: 'rh-ui-document', icon: getIconData('rh-ui-document') },

0 commit comments

Comments
 (0)