fix: fixed accessibility for pf-table

atharv-g-kulkarni · atharv-g-kulkarni · commit 7f189ae8124a · 2024-12-10T17:47:46.000+05:30
diff --git a/elements/pf-table/pf-th.ts b/elements/pf-table/pf-th.ts
@@ -51,7 +51,7 @@ export class PfTh extends LitElement {
     const closestThead = this.closest('pf-thead');
     const closestTable = this.closest('pf-table');
     const isChildOfThead = !!closestThead && !!closestTable?.contains(closestThead);
-    const role = isChildOfThead ? 'colheader' : 'rowheader';
+    const role = isChildOfThead ? 'columnheader' : 'rowheader';
     this.setAttribute('role', role);
   }
 
diff --git a/elements/pf-table/pf-tr.ts b/elements/pf-table/pf-tr.ts
@@ -110,6 +110,7 @@ export class PfTr extends LitElement {
           <pf-button id="toggle-button"
                      aria-expanded=${String(this.expanded) as 'true' | 'false'}
                      plain
+                     label="Expand Button"
                      @click=${this.#onClick}>
             <pf-icon id="toggle-icon"
                      icon="angle-right"

Original file line number	Diff line number	Diff line change
`@@ -51,7 +51,7 @@ export class PfTh extends LitElement {`
`51`	`51`	`const closestThead = this.closest('pf-thead');`
`52`	`52`	`const closestTable = this.closest('pf-table');`
`53`	`53`	`const isChildOfThead = !!closestThead && !!closestTable?.contains(closestThead);`
`54`		`- const role = isChildOfThead ? 'colheader' : 'rowheader';`
	`54`	`+ const role = isChildOfThead ? 'columnheader' : 'rowheader';`
`55`	`55`	`this.setAttribute('role', role);`
`56`	`56`	`}`
`57`	`57`