fix: return error for unreadable bearer token file#3177
Open
immanuwell wants to merge 1 commit into
Open
Conversation
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Small fix for a sharp edge in remote store auth. If
--remote-store-bearer-token-filepoints at a missing/unreadable file, setup currently panics.Now it returns the wrapped error like the TLS setup path does. Tiny thing, but no random crashy vibes.
Repro
Before this patch:
go test ./flags -run TestSetupGrpcConnectionReturnsErrorForUnreadableBearerTokenFile -count=1It panics from
setupGrpcConnection.Checks
go test ./flags -run TestSetupGrpcConnectionReturnsErrorForUnreadableBearerTokenFile -count=1go test ./...