Add psalm

Author: Robin de Graaf

.github/workflows/tests.yml

@@ -32,3 +32,6 @@ jobs:
 
     - name: Run test suite
       run: vendor/bin/phpunit tests
+
+    - name: Run static analysis
+      run: vendor/bin/psalm

.gitignore

@@ -1,4 +1,5 @@
+.DS_Store
 .idea
 composer.lock
 vendor
-coverage
+coverage

CHANGELOG.md

@@ -1,9 +1,14 @@
 # Parable Http
 
+## 0.5.2
+
+_Changes_
+- Added static analysis through psalm.
+
 ## 0.5.1
 
 _Changes_
-- `Request` can now be instantiated without passing all values, in which cases it will set itself up by using `RequestFactory::getValuesFromServer`. 
+- `Request` can now be instantiated without passing all values, in which cases it will set itself up by using `RequestFactory::getValuesFromServer`.
 
 ## 0.5.0
 

Makefile

@@ -4,6 +4,10 @@ dependencies:
 		--no-plugins \
 		--no-scripts
 
+psalm:
+	vendor/bin/psalm --clear-cache
+	vendor/bin/psalm
+
 tests: dependencies
 	vendor/bin/phpunit --verbose tests
 
@@ -13,3 +17,7 @@ coverage: dependencies
 
 tests-clean:
 	vendor/bin/phpunit --verbose tests
+
+coverage-clean:
+	rm -rf ./coverage
+	XDEBUG_MODE=coverage vendor/bin/phpunit --coverage-html ./coverage tests

composer.json

@@ -18,7 +18,8 @@
     "ralouphie/getallheaders": "^3.0"
   },
   "require-dev": {
-    "phpunit/phpunit": "^9.0"
+    "phpunit/phpunit": "^9.0",
+    "vimeo/psalm": "^4.6"
   },
   "autoload": {
     "psr-4": {

psalm.xml

@@ -0,0 +1,19 @@
+<?xml version="1.0"?>
+<psalm
+    errorLevel="4"
+    resolveFromConfigFile="true"
+    xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+    xmlns="https://getpsalm.org/schema/config"
+    xsi:schemaLocation="https://getpsalm.org/schema/config vendor/vimeo/psalm/config.xsd"
+>
+    <projectFiles>
+        <directory name="src" />
+        <ignoreFiles>
+            <directory name="vendor" />
+        </ignoreFiles>
+    </projectFiles>
+
+    <issueHandlers>
+        <UnresolvableInclude errorLevel="suppress" />
+    </issueHandlers>
+</psalm>

src/Request.php

@@ -53,7 +53,7 @@ public function getRequestUri(): ?string
 
     public function getProtocol(): string
     {
-        return $this->protocol ?? 'HTTP/1.1';
+        return $this->protocol;
     }
 
     public function getProtocolVersion(): string

src/Response.php

@@ -51,7 +51,7 @@ public function appendBody(string $content): void
 
     public function getContentType(): string
     {
-        return $this->getHeader('Content-Type');
+        return $this->getHeader('Content-Type') ?? 'text/html';
     }
 
     public function setContentType(string $contentType): void
@@ -61,7 +61,7 @@ public function setContentType(string $contentType): void
 
     public function getProtocol(): string
     {
-        return $this->protocol ?? 'HTTP/1.1';
+        return $this->protocol;
     }
 
     public function getProtocolVersion(): string