Conversation
kdeldycke
requested changes
May 23, 2026
kdeldycke
added a commit
to kdeldycke/click-extra
that referenced
this pull request
May 23, 2026
kdeldycke
requested changes
May 23, 2026
Collaborator
|
Just added that branch to my matrix of tests in Click Extra: kdeldycke/click-extra@27f3999 Tl;Dr: No colorama regressions. ResultsThe run is at https://github.com/kdeldycke/click-extra/actions/runs/26327147889 Fixed stack:
Some flaky runs had nothing to do with Colorama removal, just some CI/CD flaps from Click Extra project. Note: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tested
echo,prompt, and other output utilities in a script, and styles seem to work fine. Tested in both Terminal and cmd.exe. I'm not clear when Windows 11 enabled ANSI by default, but realistically we can only support the latest version since that's the only version we and most people can get. An application that wants to support older Windows can still require colorama and callcolorama.init()beforemain().closes #2986