Properly support multiline help string and fix broken fish completion from #3126#3504
Merged
Conversation
82fdd69 to
31eb163
Compare
Collaborator
|
OK so #3126 was a PR introducing a regression that was merge too early and broke fish completion in 8.4.0. The fix was naive as newlines can't serve double duty as both item and field separator in fish, as @sitiyou just pointed out. This PR apply the right sanitation proposed in #3126 of escaping newline characters The deeper issue is that nowhere in Click do we run fish code with fish. But that's another work entirely. So this is good to me to be merged. |
Collaborator
|
Arf. I messed up and merged this issue to |
Collaborator
|
A fix for the wrong merge target is being worked on at #3508 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #3502 for details.
This PR reverts the changes introduced in #3126 and properly handles multi-line help strings by quoting
\nand replacing\twith a space.According to the Fish documentation:
fix #3043 and #3502