Errors raised when calling Cursor.executemany() with PL/SQL now

have the offset attribute populated with the last iteration that
succeeded (#283).

Author: anthony-tuininga

doc/src/release_notes.rst

@@ -50,6 +50,10 @@ Common Changes
     columns which have the check constraint ``IS JSON FORMAT OSON`` enabled.
 #)  Added boolean property :data:`FetchInfo.is_oson` which is set when a column
     has the check constraint "IS JSON FORMAT OSON" enabled.
+#)  Errors raised when calling :meth:`Cursor.executemany()` with PL/SQL now
+    have the :data:`oracledb._Error.offset` attribute populated with the last
+    iteration that succeeded
+    (`issue 283 <https://github.com/oracle/python-oracledb/issues/283>`__).
 #)  A number of performance improvements were made.
 #)  Error ``DPY-2045: arraysize must be an integer greater than zero`` is now
     raised when an invalid value is specified for the attribute

src/oracledb/impl/thick/cursor.pyx

@@ -337,11 +337,14 @@ cdef class ThickCursorImpl(BaseCursorImpl):
             with nogil:
                 status = dpiStmt_executeMany(self._handle, mode, num_execs_int)
                 dpiContext_getError(driver_context, &error_info)
-                if not self._stmt_info.isPLSQL:
-                    dpiStmt_getRowCount(self._handle, &rowcount)
-            self.rowcount = rowcount
+                dpiStmt_getRowCount(self._handle, &rowcount)
+            if not self._stmt_info.isPLSQL:
+                self.rowcount = rowcount
             if status < 0:
-                _raise_from_info(&error_info)
+                error = _create_new_from_info(&error_info)
+                if self._stmt_info.isPLSQL and error_info.offset == 0:
+                    error.offset = rowcount
+                raise error.exc_type(error)
             elif error_info.isWarning:
                 self.warning = _create_new_from_info(&error_info)
             if self._stmt_info.isReturning or self._stmt_info.isPLSQL:

src/oracledb/impl/thin/messages.pyx

@@ -34,7 +34,7 @@ cdef class _OracleErrorInfo:
     cdef:
         uint32_t num
         uint16_t cursor_id
-        uint16_t pos
+        uint64_t pos
         uint64_t rowcount
         str message
         Rowid rowid
@@ -2160,6 +2160,8 @@ cdef class ExecuteMessage(MessageWithData):
         """
         cdef Statement stmt = self.cursor_impl._statement
         MessageWithData.process(self, buf)
+        if self.error_occurred and self.error_info.pos == 0 and stmt._is_plsql:
+            self.error_info.pos = self.error_info.rowcount + self.offset
         if not self.parse_only:
             stmt._executed = True
         if stmt._requires_define and stmt._sql is not None:

tests/test_4000_cursor_executemany.py

@@ -412,6 +412,23 @@ def test_4025(self):
             expected_value = [(67,)] * (len(values) + num_iterations)
             self.assertEqual(self.cursor.fetchall(), expected_value)
 
+    def test_4026(self):
+        "4026 - test executemany error offset returned correctly"
+        data = [(i,) for i in range(1, 11)]
+        with self.assertRaises(oracledb.Error) as cm:
+            self.cursor.executemany(
+                """
+                declare
+                    t_Value     number;
+                begin
+                    t_Value := 10 / (4 - :1);
+                end;
+                """,
+                data,
+            )
+        (error_obj,) = cm.exception.args
+        self.assertEqual(error_obj.offset, 3)
+
 
 if __name__ == "__main__":
     test_env.run_test_cases()