Fixed bug in identifying bind variables in SQL statements containing a

single line comment at the end of the statement.

Author: anthony-tuininga

doc/src/release_notes.rst

@@ -20,6 +20,8 @@ Thin Mode Changes
 #)  Fixed regression when using IAM token authentication
     (`issue 288 <https://github.com/oracle/python-oracledb/issues/288>`__).
 #)  Fixed bug when using DRCP with :ref:`asyncio <asyncio>`.
+#)  Fixed bug in identifying bind variables in SQL statements containing a
+    single line comment at the end of the statement.
 
 Thick Mode Changes
 ++++++++++++++++++

src/oracledb/impl/thin/statement.pyx

@@ -200,10 +200,10 @@ cdef class Parser:
     cdef int _parse_single_line_comment(self) except -1:
         """
         Single line comments consist of two dashes and all characters up to the
-        next line break. This method is called when the first dash is detected
-        and checks for the subsequent dash. If found, the single line comment
-        is traversed and the current position is updated; otherwise, the
-        current position is left untouched.
+        next line break (or the end of the data). This method is called when
+        the first dash is detected and checks for the subsequent dash. If
+        found, the single line comment is traversed and the current position is
+        updated; otherwise, the current position is left untouched.
         """
         cdef:
             ssize_t pos = self.pos + 1
@@ -213,12 +213,12 @@ cdef class Parser:
             ch = cpython.PyUnicode_READ(self.sql_kind, self.sql_data, pos)
             if not in_comment:
                 if ch != '-':
-                    break
+                    return 0
                 in_comment = True
             elif cpython.Py_UNICODE_ISLINEBREAK(ch):
-                self.pos = pos
                 break
             pos += 1
+        self.pos = pos
 
     cdef int parse(self, Statement stmt) except -1:
         """

tests/test_5200_sql_parser.py

@@ -36,7 +36,7 @@ def test_5200(self):
         "5200 - single line comment"
         self.cursor.prepare(
             "--begin :value2 := :a + :b + :c +:a +3; end;\n"
-            "begin :value2 := :a + :c +3; end;"
+            "begin :value2 := :a + :c +3; end; -- not a :bind_variable"
         )
         self.assertEqual(self.cursor.bindnames(), ["VALUE2", "A", "C"])