Skip to content

Commit 94a215f

Browse files
Connection parameters that are strings now treat an empty string in the
same way as the value "None".
1 parent 2fc29e4 commit 94a215f

File tree

3 files changed

+11
-2
lines changed

3 files changed

+11
-2
lines changed

doc/src/release_notes.rst

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -48,6 +48,8 @@ Common Changes
4848
mode would raise ``DPI-1040: LOB was already closed``.
4949
#) Fixed bug in :meth:`ConnectParams.get_connect_string()` when a value for
5050
the connection parameter ``purity`` has been specified.
51+
#) Connection parameters that are strings now treat an empty string in the
52+
same way as the value ``None``.
5153

5254

5355
oracledb 2.0.1 (January 2024)

src/oracledb/impl/base/utils.pyx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -163,7 +163,7 @@ cdef int _set_str_param(dict args, str name, object target) except -1:
163163
Python objects).
164164
"""
165165
in_val = args.get(name)
166-
if in_val is not None:
166+
if in_val:
167167
setattr(target, name, str(in_val))
168168

169169

tests/test_4500_connect_params.py

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -215,7 +215,7 @@ def test_4513(self):
215215
params.parse_connect_string("my_host15:1578/")
216216
self.assertEqual(params.host, "my_host15")
217217
self.assertEqual(params.port, 1578)
218-
self.assertEqual(params.service_name, "")
218+
self.assertEqual(params.service_name, None)
219219

220220
def test_4514(self):
221221
"4514 - test missing entry in tnsnames"
@@ -769,6 +769,13 @@ def test_4566(self):
769769
params.set(sdu=2097153)
770770
self.assertEqual(params.sdu, 2097152)
771771

772+
def test_4567(self):
773+
"4567 - test empty connection class"
774+
params = oracledb.ConnectParams()
775+
self.assertEqual(params.cclass, None)
776+
params.set(cclass="")
777+
self.assertEqual(params.cclass, None)
778+
772779

773780
if __name__ == "__main__":
774781
test_env.run_test_cases()

0 commit comments

Comments
 (0)