Fixed bug in calculating the connection "thin" attribute.

Author: anthony-tuininga

doc/src/api_manual/async_connection.rst

@@ -334,6 +334,12 @@ AsyncConnection Attributes
 
     See :ref:`Statement Caching <stmtcache>` for more information.
 
+.. attribute:: AsyncConnection.thin
+
+    This read-only attribute returns a boolean indicating if the connection was
+    established with the python-oracledb Thin mode (True) or python-oracledb
+    Thick mode (False).
+
 .. attribute:: AsyncConnection.transaction_in_progress
 
     This read-only attribute specifies whether a transaction is currently in

doc/src/api_manual/connection.rst

@@ -865,8 +865,9 @@ Connection Attributes
 
 .. attribute:: Connection.thin
 
-    This read-only attribute returns a boolean indicating if the connection was established
-    with the python-oracledb Thin mode (True) or python-oracledb Thick mode (False).
+    This read-only attribute returns a boolean indicating if the connection was
+    established with the python-oracledb Thin mode (True) or python-oracledb
+    Thick mode (False).
 
     .. note::
 

doc/src/release_notes.rst

@@ -29,6 +29,7 @@ Thin Mode Changes
 #)  Fixed bug in identifying bind variables in SQL statements containing a
     single line comment at the end of the statement.
 #)  Fixed bug in determining the list of attributes for PL/SQL collections.
+#)  Fixed bug in calculating the :data:`Connection.thin` attribute.
 
 Thick Mode Changes
 ++++++++++++++++++

src/oracledb/base_impl.pxd

@@ -444,6 +444,7 @@ cdef class PoolParamsImpl(ConnectParamsImpl):
 
 cdef class BaseConnImpl:
     cdef:
+        readonly bint thin
         readonly str username
         readonly str dsn
         readonly str proxy_user

src/oracledb/connection.py

@@ -399,6 +399,15 @@ def stmtcachesize(self, value: int) -> None:
         self._verify_connected()
         self._impl.set_stmt_cache_size(value)
 
+    @property
+    def thin(self) -> bool:
+        """
+        Returns a boolean indicating if the connection was established in
+        python-oracledb's thin mode (True) or thick mode (False).
+        """
+        self._verify_connected()
+        return self._impl.thin
+
     @property
     def transaction_in_progress(self) -> bool:
         """
@@ -998,15 +1007,6 @@ def tag(self, value: str) -> None:
         self._verify_connected()
         self._impl.tag = value
 
-    @property
-    def thin(self) -> bool:
-        """
-        Returns a boolean indicating if the connection was established in
-        python-oracledb's thin mode (True) or thick mode (False).
-        """
-        self._verify_connected()
-        return isinstance(self._impl, thin_impl.ThinConnImpl)
-
     def tpc_begin(
         self, xid: Xid, flags: int = constants.TPC_BEGIN_NEW, timeout: int = 0
     ) -> None:

src/oracledb/impl/thin/connection.pyx

@@ -74,6 +74,7 @@ cdef class BaseThinConnImpl(BaseConnImpl):
         if not HAS_CRYPTOGRAPHY:
             errors._raise_err(errors.ERR_NO_CRYPTOGRAPHY_PACKAGE)
         BaseConnImpl.__init__(self, dsn, params)
+        self.thin = True
 
     cdef BaseThinLobImpl _create_lob_impl(self, DbType dbtype,
                                           bytes locator=None):

tests/test_1100_connection.py

@@ -73,6 +73,7 @@ def test_1100(self):
         self.assertEqual(
             conn.dsn, test_env.get_connect_string(), "dsn differs"
         )
+        self.assertEqual(conn.thin, test_env.get_is_thin())
 
     @unittest.skipIf(
         test_env.get_is_thin(),

tests/test_5300_connection_async.py

@@ -77,6 +77,7 @@ async def test_5300(self):
         self.assertEqual(
             conn.dsn, test_env.get_connect_string(), "dsn differs"
         )
+        self.assertEqual(conn.thin, test_env.get_is_thin())
 
     async def test_5303(self):
         "5303 - test connection end-to-end tracing attributes"

utils/templates/connection.py

@@ -397,6 +397,15 @@ def stmtcachesize(self, value: int) -> None:
         self._verify_connected()
         self._impl.set_stmt_cache_size(value)
 
+    @property
+    def thin(self) -> bool:
+        """
+        Returns a boolean indicating if the connection was established in
+        python-oracledb's thin mode (True) or thick mode (False).
+        """
+        self._verify_connected()
+        return self._impl.thin
+
     @property
     def transaction_in_progress(self) -> bool:
         """
@@ -996,15 +1005,6 @@ def tag(self, value: str) -> None:
         self._verify_connected()
         self._impl.tag = value
 
-    @property
-    def thin(self) -> bool:
-        """
-        Returns a boolean indicating if the connection was established in
-        python-oracledb's thin mode (True) or thick mode (False).
-        """
-        self._verify_connected()
-        return isinstance(self._impl, thin_impl.ThinConnImpl)
-
     def tpc_begin(
         self, xid: Xid, flags: int = constants.TPC_BEGIN_NEW, timeout: int = 0
     ) -> None: