Raise error "DPY-2016: variable array size of %d is too small (should be

at least %d)" consistently when executemany() is called with an integer
number of iterations that is too large for the existing bind variables.

Author: anthony-tuininga

doc/src/release_notes.rst

@@ -66,6 +66,11 @@ Common Changes
     :data:`Cursor.arraysize`. Previously a variety of errors (``TypeError``,
     ``OverflowError`` or ``ORA-03147: missing mandatory TTC field``) were
     raised.
+#)  Error ``DPY-2016: variable array size of %d is too small (should be at
+    least %d)`` is now raised when :meth:`Cursor.executemany()` is called with
+    an integer number of iterations that is too large for the existing bind
+    variables. Previously thin mode raised ``IndexError`` and thick mode raised
+    ``DPI-1018: array size of %d is too small``.
 #)  Error ``DPY-1001: not connected to database`` is now raised when an attempt
     is made to perform an operation on a LOB using a closed connection.
     Previously Thin mode would raise an ``AttributeError`` exception and Thick

src/oracledb/base_impl.pxd

@@ -509,6 +509,7 @@ cdef class BaseCursorImpl:
                                       object params, uint32_t num_rows,
                                       uint32_t row_num,
                                       bint defer_type_assignment) except -1
+    cdef int _check_binds(self, uint32_t num_execs) except -1
     cdef int _close(self, bint in_del) except -1
     cdef BaseVarImpl _create_fetch_var(self, object conn, object cursor,
                                        object type_handler, bint

src/oracledb/impl/base/cursor.pyx

@@ -139,6 +139,20 @@ cdef class BaseCursorImpl:
             return json.loads(value)
         return converter
 
+    cdef int _check_binds(self, uint32_t num_execs) except -1:
+        """
+        Checks that all binds are capable of handling the number of executions
+        provided.
+        """
+        cdef BindVar bind_var
+        for bind_var in self.bind_vars:
+            if bind_var is None or bind_var.var_impl is None:
+                continue
+            if bind_var.var_impl.num_elements < num_execs:
+                errors._raise_err(errors.ERR_INCORRECT_VAR_ARRAYSIZE,
+                                  var_arraysize=bind_var.var_impl.num_elements,
+                                  required_arraysize=num_execs)
+
     cdef int _close(self, bint in_del) except -1:
         """
         Internal method for closing the cursor.
@@ -411,6 +425,8 @@ cdef class BaseCursorImpl:
         self.set_input_sizes = False
         if isinstance(parameters, int):
             num_execs = parameters
+            if self.bind_vars is not None:
+                self._check_binds(num_execs)
         elif isinstance(parameters, list):
             num_execs = len(parameters)
             if parameters:

tests/test_4000_cursor_executemany.py

@@ -429,6 +429,24 @@ def test_4026(self):
         (error_obj,) = cm.exception.args
         self.assertEqual(error_obj.offset, 3)
 
+    def test_4027(self):
+        "4027 - test executemany with number of iterations too small"
+        data = [[1], [2], [3]]
+        self.cursor.execute("truncate table TestTempTable")
+        self.cursor.executemany(
+            """
+            declare
+                t_Value         number;
+            begin
+                t_Value := :1;
+            end;
+            """,
+            data,
+        )
+        self.cursor.executemany(None, 2)
+        with self.assertRaisesFullCode("DPY-2016"):
+            self.cursor.executemany(None, 4)
+
 
 if __name__ == "__main__":
     test_env.run_test_cases()