Skip to content

Commit bfbd1d5

Browse files
raju-optiraju-opti
committed
fixes
1 parent d966df0 commit bfbd1d5

File tree

4 files changed

+26
-0
lines changed

4 files changed

+26
-0
lines changed

‎lib/core/decision_service/index.tests.js‎

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1261,6 +1261,7 @@ describe('lib/core/decision_service', function() {
12611261
it('returns a decision with a variation in the experiment the feature is attached to', function() {
12621262
var decision = decisionServiceInstance.getVariationForFeature(configObj, feature, user).result;
12631263
const expectedDecision = {
1264+
cmabUuid: undefined,
12641265
experiment: configObj.experimentIdMap['594098'],
12651266
variation: configObj.variationIdMap['594096'],
12661267
decisionSource: DECISION_SOURCES.FEATURE_TEST,
@@ -1332,6 +1333,7 @@ describe('lib/core/decision_service', function() {
13321333
it('returns a decision with a variation in an experiment in a group', function() {
13331334
var decision = decisionServiceInstance.getVariationForFeature(configObj, feature, user).result;
13341335
var expectedDecision = {
1336+
cmabUuid: undefined,
13351337
experiment: configObj.experimentIdMap['595010'],
13361338
variation: configObj.variationIdMap['595008'],
13371339
decisionSource: DECISION_SOURCES.FEATURE_TEST,
@@ -1666,6 +1668,7 @@ describe('lib/core/decision_service', function() {
16661668
var decision = decisionServiceInstance.getVariationForFeature(configObj, feature, user).result;
16671669
var expectedExperiment = projectConfig.getExperimentFromKey(configObj, 'group_2_exp_1');
16681670
var expectedDecision = {
1671+
cmabUuid: undefined,
16691672
experiment: expectedExperiment,
16701673
variation: {
16711674
id: '38901',
@@ -1693,6 +1696,7 @@ describe('lib/core/decision_service', function() {
16931696
var decision = decisionServiceInstance.getVariationForFeature(configObj, feature, user).result;
16941697
var expectedExperiment = projectConfig.getExperimentFromKey(configObj, 'group_2_exp_2');
16951698
var expectedDecision = {
1699+
cmabUuid: undefined,
16961700
experiment: expectedExperiment,
16971701
variation: {
16981702
id: '38905',
@@ -1720,6 +1724,7 @@ describe('lib/core/decision_service', function() {
17201724
var decision = decisionServiceInstance.getVariationForFeature(configObj, feature, user).result;
17211725
var expectedExperiment = projectConfig.getExperimentFromKey(configObj, 'group_2_exp_3');
17221726
var expectedDecision = {
1727+
cmabUuid: undefined,
17231728
experiment: expectedExperiment,
17241729
variation: {
17251730
id: '38906',
@@ -1802,6 +1807,7 @@ describe('lib/core/decision_service', function() {
18021807
var decision = decisionServiceInstance.getVariationForFeature(configObj, feature, user).result;
18031808
var expectedExperiment = projectConfig.getExperimentFromKey(configObj, 'test_experiment3');
18041809
var expectedDecision = {
1810+
cmabUuid: undefined,
18051811
experiment: expectedExperiment,
18061812
variation: {
18071813
id: '222239',
@@ -1830,6 +1836,7 @@ describe('lib/core/decision_service', function() {
18301836
var decision = decisionServiceInstance.getVariationForFeature(configObj, feature, user).result;
18311837
var expectedExperiment = projectConfig.getExperimentFromKey(configObj, 'test_experiment4');
18321838
var expectedDecision = {
1839+
cmabUuid: undefined,
18331840
experiment: expectedExperiment,
18341841
variation: {
18351842
id: '222240',
@@ -1858,6 +1865,7 @@ describe('lib/core/decision_service', function() {
18581865
var decision = decisionServiceInstance.getVariationForFeature(configObj, feature, user).result;
18591866
var expectedExperiment = projectConfig.getExperimentFromKey(configObj, 'test_experiment5');
18601867
var expectedDecision = {
1868+
cmabUuid: undefined,
18611869
experiment: expectedExperiment,
18621870
variation: {
18631871
id: '222241',

‎lib/event_processor/event_builder/user_event.tests.js‎

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -142,6 +142,7 @@ describe('user_event', function() {
142142
flagKey: 'flagkey1',
143143
ruleType: 'experiment',
144144
enabled: true,
145+
cmabUuid: undefined,
145146
});
146147
});
147148
});
@@ -235,6 +236,7 @@ describe('user_event', function() {
235236
flagKey: 'flagkey1',
236237
ruleType: 'experiment',
237238
enabled: false,
239+
cmabUuid: undefined,
238240
});
239241
});
240242
});

‎lib/optimizely/index.spec.ts‎

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -86,6 +86,7 @@ describe('Optimizely', () => {
8686
cmabService: {} as any
8787
});
8888

89+
// eslint-disable-next-line @typescript-eslint/ban-ts-comment
8990
// @ts-ignore
9091
const decisionService = optimizely.decisionService;
9192
vi.spyOn(decisionService, 'resolveVariationsForFeatureList').mockImplementation(() => {
@@ -138,6 +139,7 @@ describe('Optimizely', () => {
138139
cmabService: {} as any
139140
});
140141

142+
// eslint-disable-next-line @typescript-eslint/ban-ts-comment
141143
// @ts-ignore
142144
const decisionService = optimizely.decisionService;
143145
vi.spyOn(decisionService, 'resolveVariationsForFeatureList').mockImplementation(() => {

‎lib/optimizely/index.tests.js‎

Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -239,6 +239,7 @@ describe('lib/optimizely', function() {
239239

240240
sinon.assert.calledWith(decisionService.createDecisionService, {
241241
userProfileService: userProfileServiceInstance,
242+
userProfileServiceAsync: undefined,
242243
logger: createdLogger,
243244
cmabService,
244245
UNSTABLE_conditionEvaluators: undefined,
@@ -270,6 +271,7 @@ describe('lib/optimizely', function() {
270271

271272
sinon.assert.calledWith(decisionService.createDecisionService, {
272273
userProfileService: undefined,
274+
userProfileServiceAsync: undefined,
273275
logger: createdLogger,
274276
UNSTABLE_conditionEvaluators: undefined,
275277
cmabService,
@@ -368,6 +370,7 @@ describe('lib/optimizely', function() {
368370
rule_type: 'experiment',
369371
variation_key: 'variation',
370372
enabled: true,
373+
cmab_uuid: undefined,
371374
},
372375
},
373376
],
@@ -432,6 +435,7 @@ describe('lib/optimizely', function() {
432435
rule_type: 'experiment',
433436
variation_key: 'variationWithAudience',
434437
enabled: true,
438+
cmab_uuid: undefined,
435439
},
436440
},
437441
],
@@ -501,6 +505,7 @@ describe('lib/optimizely', function() {
501505
rule_type: 'experiment',
502506
variation_key: 'variationWithAudience',
503507
enabled: true,
508+
cmab_uuid: undefined,
504509
},
505510
},
506511
],
@@ -575,6 +580,7 @@ describe('lib/optimizely', function() {
575580
rule_type: 'experiment',
576581
variation_key: 'variationWithAudience',
577582
enabled: true,
583+
cmab_uuid: undefined,
578584
},
579585
},
580586
],
@@ -682,6 +688,7 @@ describe('lib/optimizely', function() {
682688
rule_type: 'experiment',
683689
variation_key: 'var2exp2',
684690
enabled: true,
691+
cmab_uuid: undefined,
685692
},
686693
},
687694
],
@@ -744,6 +751,7 @@ describe('lib/optimizely', function() {
744751
rule_type: 'experiment',
745752
variation_key: 'var2exp1',
746753
enabled: true,
754+
cmab_uuid: undefined,
747755
},
748756
},
749757
],
@@ -2245,6 +2253,7 @@ describe('lib/optimizely', function() {
22452253
rule_type: 'experiment',
22462254
variation_key: 'variation',
22472255
enabled: true,
2256+
cmab_uuid: undefined,
22482257
},
22492258
},
22502259
],
@@ -2307,6 +2316,7 @@ describe('lib/optimizely', function() {
23072316
rule_type: 'experiment',
23082317
variation_key: 'variation',
23092318
enabled: true,
2319+
cmab_uuid: undefined,
23102320
},
23112321
},
23122322
],
@@ -4542,6 +4552,7 @@ describe('lib/optimizely', function() {
45424552
rule_type: 'feature-test',
45434553
variation_key: 'variation_with_traffic',
45444554
enabled: true,
4555+
cmab_uuid: undefined,
45454556
},
45464557
},
45474558
],
@@ -6231,6 +6242,7 @@ describe('lib/optimizely', function() {
62316242
rule_type: 'feature-test',
62326243
variation_key: 'variation',
62336244
enabled: true,
6245+
cmab_uuid: undefined,
62346246
},
62356247
},
62366248
],
@@ -6458,6 +6470,7 @@ describe('lib/optimizely', function() {
64586470
rule_type: 'feature-test',
64596471
variation_key: 'control',
64606472
enabled: false,
6473+
cmab_uuid: undefined,
64616474
},
64626475
},
64636476
],
@@ -6661,6 +6674,7 @@ describe('lib/optimizely', function() {
66616674
rule_type: 'rollout',
66626675
variation_key: '',
66636676
enabled: false,
6677+
cmab_uuid: undefined,
66646678
},
66656679
},
66666680
],

0 commit comments

Comments
 (0)