more validation

Author: raju-opti

lib/event_processor/event_processor_factory.spec.ts

@@ -73,6 +73,59 @@ describe('getBatchEventProcessor', () => {
     })).toThrow('Invalid event dispatcher');
   });
 
+  it('should throw and error if provided event store is invalid', () => {
+    expect(() => getBatchEventProcessor({
+      eventDispatcher: getMockEventDispatcher(),
+      defaultFlushInterval: 10000,
+      defaultBatchSize: 10,
+      eventStore: 'abc' as any,
+    })).toThrow('Invalid event store');
+
+    expect(() => getBatchEventProcessor({
+      eventDispatcher: getMockEventDispatcher(),
+      defaultFlushInterval: 10000,
+      defaultBatchSize: 10,
+      eventStore: 123 as any,
+    })).toThrow('Invalid event store');
+
+    expect(() => getBatchEventProcessor({
+      eventDispatcher: getMockEventDispatcher(),
+      defaultFlushInterval: 10000,
+      defaultBatchSize: 10,
+      eventStore: {} as any,
+    })).toThrow('Invalid store method set, Invalid store method get, Invalid store method remove, Invalid store method getKeys');
+
+    expect(() => getBatchEventProcessor({
+      eventDispatcher: getMockEventDispatcher(),
+      defaultFlushInterval: 10000,
+      defaultBatchSize: 10,
+      eventStore: { set: 'abc', get: 'abc', remove: 'abc', getKeys: 'abc' } as any,
+    })).toThrow('Invalid store method set, Invalid store method get, Invalid store method remove, Invalid store method getKeys');
+
+    const noop = () => {};
+
+    expect(() => getBatchEventProcessor({
+      eventDispatcher: getMockEventDispatcher(),
+      defaultFlushInterval: 10000,
+      defaultBatchSize: 10,
+      eventStore: { set: noop, get: 'abc' } as any,
+    })).toThrow('Invalid store method get, Invalid store method remove, Invalid store method getKeys');
+
+    expect(() => getBatchEventProcessor({
+      eventDispatcher: getMockEventDispatcher(),
+      defaultFlushInterval: 10000,
+      defaultBatchSize: 10,
+      eventStore: { set: noop, get: noop, remove: 'abc' } as any,
+    })).toThrow('Invalid store method remove, Invalid store method getKeys');
+
+    expect(() => getBatchEventProcessor({
+      eventDispatcher: getMockEventDispatcher(),
+      defaultFlushInterval: 10000,
+      defaultBatchSize: 10,
+      eventStore: { set: noop, get: noop, remove: noop, getKeys: 'abc' } as any,
+    })).toThrow('Invalid store method getKeys');
+  });
+
   it('returns an instane of BatchEventProcessor if no subclass constructor is provided', () => {
     const options = {
       eventDispatcher: getMockEventDispatcher(),

lib/event_processor/event_processor_factory.ts

@@ -29,6 +29,9 @@ export const INVALID_EVENT_DISPATCHER = 'Invalid event dispatcher';
 export const FAILED_EVENT_RETRY_INTERVAL = 20 * 1000; 
 export const EVENT_STORE_PREFIX = 'optly_event:';
 
+export const INVALID_STORE = 'Invalid event store';
+export const INVALID_STORE_METHOD = 'Invalid store method %s';
+
 export const getPrefixEventStore = (store: Store<string>): Store<EventWithId> => {
   if (store.operation === 'async') {
     return new AsyncPrefixStore<string, EventWithId>(
@@ -81,6 +84,23 @@ export const validateEventDispatcher = (eventDispatcher: EventDispatcher): void
   }
 }
 
+const validateStore = (store: any) => {
+  const errors = [];
+  if (!store || typeof store !== 'object') {
+    throw new Error(INVALID_STORE);
+  }
+
+  for (const method of ['set', 'get', 'remove', 'getKeys']) {
+    if (typeof store[method] !== 'function') {
+      errors.push(INVALID_STORE_METHOD.replace('%s', method));
+    }
+  }
+
+  if (errors.length > 0) {
+    throw new Error(errors.join(', '));
+  }
+}
+
 export const getBatchEventProcessor = (
     options: BatchEventProcessorFactoryOptions,
     EventProcessorConstructor: typeof BatchEventProcessor = BatchEventProcessor
@@ -92,6 +112,10 @@ export const getBatchEventProcessor = (
     validateEventDispatcher(closingEventDispatcher);
   }
 
+  if (eventStore) {
+    validateStore(eventStore);
+  }
+  
   const retryConfig: RetryConfig | undefined = retryOptions ? {
     maxRetries: retryOptions.maxRetries,
     backoffProvider: () => {

lib/odp/odp_manager_factory.ts

@@ -67,7 +67,6 @@ export type OdpManagerFactoryOptions = Omit<OdpManagerOptions,  'segmentsApiTime
 const validateCache = (cache: any) => {
   const errors = [];
   if (!cache || typeof cache !== 'object') {
-    console.log('what  ', cache, typeof cache);
     throw new Error(INVALID_CACHE);
   }