refactor: extract tryCreate helper to reduce repetition in create()

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

Author: muzahidul-opti

core-api/src/main/java/com/optimizely/ab/event/internal/serializer/DefaultJsonSerializer.java

@@ -22,6 +22,8 @@
 import com.optimizely.ab.config.parser.MissingJsonParserException;
 
 import javax.annotation.Nonnull;
+import javax.annotation.Nullable;
+import java.util.concurrent.Callable;
 
 /**
  * Factory for generating {@link Serializer} instances, based on the json library available on the classpath.
@@ -47,47 +49,30 @@ public static Serializer getInstance() {
      */
     private static @Nonnull
     Serializer create() {
-        if (isPresent("com.fasterxml.jackson.databind.ObjectMapper")) {
-            try {
-                Serializer serializer = new JacksonSerializer();
-                logger.debug("using json serializer: {}", serializer.getClass().getSimpleName());
-                return serializer;
-            } catch (Throwable t) {
-                logger.warn("Jackson found on classpath but serializer initialization failed, trying next option.", t);
-            }
+        Serializer serializer;
+        if ((serializer = tryCreate("com.fasterxml.jackson.databind.ObjectMapper", JacksonSerializer::new)) != null ||
+            (serializer = tryCreate("com.google.gson.Gson", GsonSerializer::new)) != null ||
+            (serializer = tryCreate("org.json.simple.JSONObject", JsonSimpleSerializer::new)) != null ||
+            (serializer = tryCreate("org.json.JSONObject", JsonSerializer::new)) != null) {
+            logger.debug("using json serializer: {}", serializer.getClass().getSimpleName());
+            return serializer;
         }
-        if (isPresent("com.google.gson.Gson")) {
-            try {
-                Serializer serializer = new GsonSerializer();
-                logger.debug("using json serializer: {}", serializer.getClass().getSimpleName());
-                return serializer;
-            } catch (Throwable t) {
-                logger.warn("Gson found on classpath but serializer initialization failed, trying next option.", t);
-            }
-        }
-        if (isPresent("org.json.simple.JSONObject")) {
-            try {
-                Serializer serializer = new JsonSimpleSerializer();
-                logger.debug("using json serializer: {}", serializer.getClass().getSimpleName());
-                return serializer;
-            } catch (Throwable t) {
-                logger.warn("json-simple found on classpath but serializer initialization failed, trying next option.", t);
-            }
-        }
-        if (isPresent("org.json.JSONObject")) {
-            try {
-                Serializer serializer = new JsonSerializer();
-                logger.debug("using json serializer: {}", serializer.getClass().getSimpleName());
-                return serializer;
-            } catch (Throwable t) {
-                logger.warn("org.json found on classpath but serializer initialization failed.", t);
-            }
-        }
-
         throw new MissingJsonParserException("unable to locate a JSON parser. "
             + "Please see <link> for more information");
     }
 
+    private static @Nullable Serializer tryCreate(String className, Callable<Serializer> factory) {
+        if (!isPresent(className)) {
+            return null;
+        }
+        try {
+            return factory.call();
+        } catch (Throwable t) {
+            logger.warn("{} found on classpath but serializer init failed, trying next option.", className, t);
+            return null;
+        }
+    }
+
     private static boolean isPresent(@Nonnull String className) {
         try {
             Class.forName(className);