-
Notifications
You must be signed in to change notification settings - Fork 5
Open
Description
At entry_point.sh all side files are processed by runner
selenium-side-runner (...) /sides/*.side
But plugin script check_selenium_docker.py wait for and process only the first json output:
side = glob.glob(path + '/sides/*.side')
side_file = open(side[0],'r')
(...)
result = path + '/out/' + side_json['name'] + '.json'
(...)
while not os.path.isfile(result) and waitedfor <= timeout:
It also calculates exec_time and prints failureMessage based only on the first failed test. If side file contains more than one Test Suite then could be more failed tests:
int(str(json_input['testResults'][0]['endTime'])[:-3]) - int(str(json_input['startTime'])[:-3])
(...)
" tests. Error message: " + str(json_input['testResults'][0]['message']) +
And finally runner's output failure messages are quite long and multi-line which is a bit in a contrary with a Nagions Guidelines that encourages brevity.
I fixed it all in my fork. I will do a PR if you would like to merge it.
ps. Good job with this plugin :).
Metadata
Metadata
Assignees
Labels
No labels