gstreamer1: fix build failures when cross-compiling#29519
Open
dangowrt wants to merge 1 commit into
Open
Conversation
Two pre-existing issues prevented gstreamer1 from building on some
host/target combinations:
* meson.build probed for the Solaris/Illumos networking libraries
('-lsocket' / '-lnsl') unconditionally via cc.find_library(),
although the comment right above the probe already scopes it to
those platforms. When the build host has a 'libnsl' package
installed, meson locates the host's /usr/lib/libnsl.so and adds
its absolute path to the link line, breaking the cross link with
an "incompatible file type" error. Add a patch which gates the
probe on host_machine.system() == 'sunos'.
* The unit test suite was built because the 'tests' meson option
was left at its 'auto' default. tests/check/gst/gstutils.c pulls
in <gsl/gsl_rng.h> from the GNU Scientific Library, which is not
packaged. Pass -Dtests=disabled; the libgstcheck helper library
is still built via -Dcheck=enabled.
Signed-off-by: Daniel Golle <daniel@makrotopia.org>
Contributor
|
Dirty patch? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📦 Package Details
Maintainer: @thess @flyn-org
Description:
Fixes two pre-existing issues that prevented gstreamer1 from building on some host/target combinations:
meson.buildprobed for the Solaris/Illumos networking libraries (-lsocket/-lnsl) unconditionally viacc.find_library(), although the comment right above the probe already scopes it to those platforms. When the build host has alibnslpackage installed (e.g. Arch Linux), meson locates the host's/usr/lib/libnsl.soand adds its absolute path to the link line, breaking the cross link withmold: fatal: /usr/lib/libnsl.so: incompatible file type. A patch gates the probe onhost_machine.system() == 'sunos'.testsmeson option was left at itsautodefault.tests/check/gst/gstutils.cpulls in<gsl/gsl_rng.h>from the GNU Scientific Library, which is not packaged.-Dtests=disabledis now passed; thelibgstcheckhelper library is still built via-Dcheck=enabled.🧪 Run Testing Details
✅ Formalities
If your PR contains a patch:
git am