Skip to content

nmap: bump to 7.99#29511

Open
smallprogram wants to merge 1 commit into
openwrt:masterfrom
smallprogram:nmap-7.99
Open

nmap: bump to 7.99#29511
smallprogram wants to merge 1 commit into
openwrt:masterfrom
smallprogram:nmap-7.99

Conversation

@smallprogram
Copy link
Copy Markdown
Contributor

@smallprogram smallprogram commented May 22, 2026

📦 Package Details

Maintainer: @nunojpg
(You can find this by checking the history of the package Makefile.)

Description:
nmap: bump to 7.99


🧪 Run Testing Details

  • OpenWrt Version: Openwrt Snapshot
  • OpenWrt Target/Subtarget: X86/64
  • OpenWrt Device: R2

✅ Formalities

  • I have reviewed the CONTRIBUTING.md file for detailed contributing guidelines.

If your PR contains a patch:

  • It can be applied using git am
  • It has been refreshed to avoid offsets, fuzzes, etc., using
    make package/<your-package>/refresh V=s
  • It is structured in a way that it is potentially upstreamable
    (e.g., subject line, commit description, etc.)
    We must try to upstream patches to reduce maintenance burden.

@GeorgeSapkin
Copy link
Copy Markdown
Member

GeorgeSapkin commented May 22, 2026

I have asked you multiple times in the past to please read and follow the contributing guidelines:

Edit: and yet again you didn't tag the maintainer.

Comment thread net/nmap/Makefile
Comment on lines -105 to -109
define Package/ndiff
$(call Package/nmap/default)
DEPENDS:=+python3-light +python3-xml
TITLE:=Utility to compare the results of Nmap scans
endef
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did you change all of these in a minor version bump?

@GeorgeSapkin GeorgeSapkin marked this pull request as draft May 22, 2026 13:03
@nunojpg
Copy link
Copy Markdown
Member

nunojpg commented May 23, 2026

You are removing ndiff? That needs to have an explanation in the commit, if some exists.

@smallprogram smallprogram marked this pull request as ready for review May 23, 2026 15:32
@smallprogram
Copy link
Copy Markdown
Contributor Author

You are removing ndiff? That needs to have an explanation in the commit, if some exists.

When upgrading Nmap to version 7.99, retaining the existing ndiff configuration results in a compilation error, specifically:

can't open file '.../ndiff/setup.py': No such file or directory

The root cause is that Nmap version 7.99 has undergone a major overhaul of the build system for its Python-based tools (such as ndiff and Zenmap):

In Nmap 7.94, ndiff still relied on the traditional Python setup.py script for packaging and installation.

By Nmap 7.99, the project officially deprecated setup.py entirely, transitioning instead to modern Python packaging standards (utilizing pyproject.toml and wheel).

Consequently, simply updating the version number and hash was insufficient; I therefore removed the obsolete elements from the Makefile, and the build subsequently passed all compilation tests.

@nunojpg
Copy link
Copy Markdown
Member

nunojpg commented May 23, 2026

I think there could be a argument to remove ndiff if no one is interested in supporting it for a few years, but wouldn't trade a version bump for removing ndiff without a significant reason.

@smallprogram
Copy link
Copy Markdown
Contributor Author

smallprogram commented May 23, 2026

I think there could be a argument to remove ndiff if no one is interested in supporting it for a few years, but wouldn't trade a version bump for removing ndiff without a significant reason.

Alright, let's put this PR on hold for now. This is the only approach I have at the moment; perhaps you might have a better solution.

Thank you for taking the time to reply. I apologize for the intrusion.

- Update nmap to version 7.99
- Fix build error

Signed-off-by: David Mandy <smallprogram@foxmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants