Skip to content

Agentic skill for feature demo#2689

Open
evgeny-s wants to merge 1 commit into
devnet-readyfrom
agent-skill-feature-demo
Open

Agentic skill for feature demo#2689
evgeny-s wants to merge 1 commit into
devnet-readyfrom
agent-skill-feature-demo

Conversation

@evgeny-s
Copy link
Copy Markdown
Collaborator

Description

This PR introduces an agentic skill for the feature demo (technical/non-technical).

Related Issue(s)

  • Closes #[issue number]

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Other (please describe):

Breaking Change

If this PR introduces a breaking change, please provide a detailed description of the impact and the migration path for existing applications.

Checklist

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have run ./scripts/fix_rust.sh to ensure my code is formatted and linted correctly
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Screenshots (if applicable)

Please include any relevant screenshots or GIFs that demonstrate the changes made.

Additional Notes

Please provide any additional information or context that may be helpful for reviewers.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 22, 2026

🛡️ AI Review — Skeptic (security review)

VERDICT: SAFE

BASELINE scrutiny: established account with repo write permission and prior substantive subtensor PRs; no Gittensor allowlist hit found; branch agent-skill-feature-demo -> devnet-ready.

Static Skeptic review found the patch limited to new markdown skill instructions under .agents/skills/feature-demo/ and .claude/skills/feature-demo/. It does not modify runtime or pallet code, workflows, trusted .github/ai-review/* files, .github/copilot-instructions.md, build scripts, Cargo manifests, or lockfiles.

Findings

No findings.

Conclusion

No malicious behavior or security vulnerability was found in the PR diff. The added skill docs scaffold demo apps into gitignored tmp/ and do not introduce an automatic CI, deployment, secret-handling, or chain-runtime execution path.


🔍 AI Review — Auditor (domain review)

VERDICT: 👍

Gittensor UNKNOWN; established contributor with repo write permission and multiple prior subtensor PRs.

The Auditor proposed a replacement PR description, but the current body is non-trivial; not overwriting. Maintainers: ask the Auditor to regenerate if you want it.

This PR adds markdown-only feature-demo skill instructions under .agents/skills/feature-demo/ and .claude/skills/feature-demo/. It does not touch runtime, pallets, Cargo manifests, workflows, or build scripts, so no spec version bump or runtime test is required.

Duplicate-work check: no overlapping open PRs were reported. Auto-fix: not needed; git diff --check passed.

Findings

No findings.

Conclusion

The added skill documentation is consistent across the .agents and .claude trees and keeps generated demo projects in gitignored tmp/. I found no domain issues that should block merge.

@github-actions
Copy link
Copy Markdown
Contributor

🔄 AI review updated — Skeptic: SAFE Auditor: 👍

@evgeny-s evgeny-s added the skip-cargo-audit This PR fails cargo audit but needs to be merged anyway label May 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip-cargo-audit This PR fails cargo audit but needs to be merged anyway

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant