[WIP] SPIKE: Onboard LPComp for LP Interop Component Readiness (Sippy)

[oharan2]

Summary

Onboard LPComp for LP Interop Component Readiness (Sippy).

Identifier	Value
LayeredProduct variant	lp-interop-lpcomp
Periodic substring	-lp-interop-cr-lpcomp
Mapped JUnit suite	lp-ocp-compat--LPComp
CR view	4.22-LP-Interop
DefaultJiraComponent	LPComp

Changes

• pkg/variantregistry/ocp.go: add setLayeredProduct entry after -lp-interop-cr-mta
• config/views.yaml: add lp-interop-lpcomp under 4.22-LP-Interop → LayeredProduct (alphabetical)
• pkg/db/suites.go: no change — existing ^lp-ocp-compat-- pattern covers suite import

Related PRs

• openshift-eng/ci-test-mapping: [WIP] SPIKE: Onboard LPComp for LP Interop Component Readiness (ci-test-mapping) openshift-eng/ci-test-mapping#722

Maintainer make

make update-variants was attempted but failed locally (BigQuery service account required). TRT/maintainer should run before merge:

make update-variants

Source: [ocp-ci-docs] LP_Interop_CR_Agent_Playbook

Summary by CodeRabbit

• New Features
  • Added support for a new layered product variant with automatic classification and identification of associated jobs and configurations.

[openshift-merge-bot]

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: automatic mode

[coderabbitai]

Walkthrough

This PR adds support for a new lp-interop-lpcomp layered product variant by updating the views configuration to include it in the 4.22-LP-Interop variant and extending the job classification logic to recognize jobs with the -lp-interop-cr-lpcomp substring.

Changes

Layered Product Variant Support

Layer / File(s)	Summary
Layered product variant declaration and classification config/views.yaml, pkg/variantregistry/ocp.go	Configuration adds lp-interop-lpcomp to the 4.22-LP-Interop variant's included layered products. Job classification logic extends the setLayeredProduct pattern matcher to recognize jobs containing -lp-interop-cr-lpcomp and map them to this variant.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

🚥 Pre-merge checks | ✅ 15 | ❌ 2

❌ Failed checks (1 warning, 1 inconclusive)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.
Title check	❓ Inconclusive	The title contains a [WIP] prefix and uses vague introductory language ('SPIKE') that obscures the actual change; the concrete change is adding LPComp onboarding, but this is buried after generic framing.	Remove [WIP] and 'SPIKE' prefixes; use a clear, direct title like 'Add LPComp to LP Interop Component Readiness variant' to make the primary change immediately obvious.

✅ Passed checks (15 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Go Error Handling	✅ Passed	PR adds a single struct entry to setLayeredProduct function with no error handling, panic calls, error ignoring, or unsafe pointer dereferences. All Go error handling patterns are properly observed.
Sql Injection Prevention	✅ Passed	The PR changes only add configuration entries (YAML) and a hardcoded pattern to a static array in ocp.go; no SQL queries are constructed or modified, and no user input is used in query building.
Excessive Css In React Should Use Styles	✅ Passed	PR modifies only YAML and Go files; no React components or CSS styling present. Custom check for React inline CSS not applicable.
Test Coverage For New Features	✅ Passed	Changes are configuration-only and exempt from test requirement per custom check exceptions. views.yaml is YAML config; ocp.go adds single entry to hardcoded data structure list.
Single Responsibility And Clear Naming	✅ Passed	Changes follow single responsibility principles: YAML entry maintains alphabetical order; code adds one matcher entry to setLayeredProduct pattern table, consistent with similar setter functions.
Stable And Deterministic Test Names	✅ Passed	PR modifies only configuration and variant registry files (config/views.yaml and pkg/variantregistry/ocp.go), not test files. No Ginkgo tests are modified.
Test Structure And Quality	✅ Passed	PR modifies configuration and variant registry code only. No Ginkgo test code is modified; codebase uses standard Go testing package.
Microshift Test Compatibility	✅ Passed	PR adds no Ginkgo e2e tests. Changes are configuration and variant registry updates only, not test code subject to the MicroShift compatibility check.
Single Node Openshift (Sno) Test Compatibility	✅ Passed	This PR makes configuration and variant registry changes to Sippy (OpenShift CI tool), not adding any new Ginkgo e2e tests. The check for SNO compatibility is not applicable.
Topology-Aware Scheduling Compatibility	✅ Passed	PR modifies only test infrastructure code (Sippy dashboard config and job classification), not Kubernetes manifests, operators, or controllers. No scheduling constraints.
Ote Binary Stdout Contract	✅ Passed	No stdout-writing code introduced. Config file is data-only; Go change adds a string pattern to a struct in setLayeredProduct() which has no stdout writes and is not called from process-level code.
Ipv6 And Disconnected Network Test Compatibility	✅ Passed	PR adds configuration and variant registry entries only; no Ginkgo e2e tests are added. The custom check applies only to new test code.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: oharan2
Once this PR has been reviewed and has the lgtm label, please assign neisw for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-merge-bot]

Scheduling required tests:
/test e2e

[openshift-ci]

@oharan2: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.