Skip to content

removing temperature param and pass threshold.#2932

Open
sriroopar wants to merge 1 commit into
openshift:mainfrom
sriroopar:fix_threshold_temp
Open

removing temperature param and pass threshold.#2932
sriroopar wants to merge 1 commit into
openshift:mainfrom
sriroopar:fix_threshold_temp

Conversation

@sriroopar
Copy link
Copy Markdown
Contributor

@sriroopar sriroopar commented May 15, 2026

Description

gpt 5 mini doesnt support temperature param, removing it temporarily and removing threshold, as only 50 percent of evals are passing in ci

Type of change

  • Refactor
  • New feature
  • Bug fix
  • CVE fix
  • Optimization
  • Documentation Update
  • Configuration Update
  • Bump-up dependent library
  • Bump-up library or tool used for development (does not change the final image)
  • CI configuration change
  • Konflux configuration change

Related Tickets & Documents

  • Related Issue #
  • Closes #

Checklist before requesting a review

  • I have performed a self-review of my code.
  • PR has passed all pre-merge test jobs.
  • If it is a core feature, I have added thorough tests.

Testing

  • Please provide detailed steps to perform tests related to this code change.
  • How were the fix/results from this change verified? Please provide relevant screenshots or results.

@openshift-ci openshift-ci Bot requested review from joshuawilson and raptorsun May 15, 2026 18:10
@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented May 15, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign bparees for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sriroopar sriroopar force-pushed the fix_threshold_temp branch from 5434039 to fa4409f Compare May 15, 2026 19:35
@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented May 15, 2026

@sriroopar: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant